Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2011 at 23:28 UTC
Updated:
13 Jun 2012 at 04:04 UTC
I was not able to find a module that did what my module does. The closest thing I found was this: http://drupal.org/node/496544
I'm submitting this because there seems to be a need for such a thing as described below:
It's basically a webform with an thank you email and page after you sign up. For years we just used webform to do what we needed for giveaways but found it really didn't cut it for us so I wrote this module. In the next version I'll include the cck type in the install function.
Project page link: http://drupal.org/sandbox/dshumaker/1307946
git repository link: http://drupalcode.org/sandbox/dshumaker/1307946.git/tree/HEAD
This module is for drupal 6.19 and up.
Comments
Comment #1
gregglesCan you go into more detail on that?
For this, it's better to use double quotes and not escape the ' - that helps translators.
t('This is a test description and wish I didn\'t need it.'),Need quotes on access_thank_you
I think access_thank_you should also have a check for node_access('view') on the node.
I noticed some very small code style issues. Please run the coder module on "minor" setting to help catch these. The coding standards have even more information in this area.
dsm won't work unless you add a dependency on devel, but I think really you want drupal_set_message.
This should use a db_query placeholder like elsewhere in the module:
As far as I know this comment isn't true. I'd like to hear more details on it to understand under what scenarios it is happening:
You need a "core = 6.x" in your .info
I think the review should be postponed until the giveaway content type is exported and created automatically.
Comment #2
avpadernoThere have not been any reply on the past two months; I am changing the status to won't fix.