duplicate titles on articles

Hmmm, I need to check this out. I'll post a fix etc shortly.

I posted a fix but actually I missed more commits, wow, bad man, posting update shortly

OK, this is a missed commits before release, so shit bugger, my bad...

There are several updates needed here - first in node tpl and then in page tpl - the idea is to print the title for nodes in node tpl always, and never in page tpl when viewing a node, this preserves the outline or page structure in HTML5.

node.tpl.php - use this instead:

<article id="article-<?php print $node->nid; ?>" class="<?php print $classes; ?> clearfix"<?php print $attributes; ?>>

  <?php print $unpublished; ?>

  <?php print render($title_prefix); ?>
  <?php if(!empty($user_picture) || $title || (!empty($submitted) && $display_submitted)): ?>
    <header class="clearfix<?php $user_picture ? print ' with-picture' : ''; ?>">

      <?php print $user_picture; ?>

      <?php if ($title): ?>
        <h1<?php print $title_attributes; ?>>
          <?php if ($page): ?>
            <?php print $title; ?>
          <?php elseif (!$page): ?>
            <a href="<?php print $node_url; ?>" rel="bookmark"><?php print $title; ?></a>
          <?php endif; ?>
        </h1>
      <?php endif; ?>

      <?php if ($display_submitted): ?>
        <div class="submitted"><?php print $submitted; ?></div>
      <?php endif; ?>

    </header>
  <?php endif; ?>
  <?php print render($title_suffix); ?>

  <div<?php print $content_attributes; ?>>
  <?php
    hide($content['comments']);
    hide($content['links']);
    print render($content);
  ?>
  </div>

  <?php if ($links = render($content['links'])): ?>
    <nav class="clearfix"><?php print $links; ?></nav>
  <?php endif; ?>

  <?php print render($content['comments']); ?>

</article>

page.tpl.php - the page title and "header" section is totally rewritten:

      <?php $tag = $title ? 'section' : 'div'; ?>
      <<?php print $tag; ?> id="main-content" role="main">

        <?php print render($title_prefix); ?>
        <?php if ($title && !isset($node)): ?>
          <header>
            <h1 id="page-title"><?php print $title; ?></h1>
          </header>
        <?php endif; ?>
        <?php print render($title_suffix); ?>

        <?php if ($primary_local_tasks || $secondary_local_tasks || $action_links): ?>
          <div id="tasks" class="clearfix">
            <?php if ($primary_local_tasks): ?>
              <ul class="tabs primary clearfix"><?php print render($primary_local_tasks); ?></ul>
            <?php endif; ?>
            <?php if ($secondary_local_tasks): ?>
              <ul class="tabs secondary clearfix"><?php print render($secondary_local_tasks); ?></ul>
            <?php endif; ?>
            <?php if ($action_links = render($action_links)): ?>
              <ul class="action-links clearfix"><?php print $action_links; ?></ul>
            <?php endif; ?>
          </div>
        <?php endif; ?>

        <div id="content"><?php print render($page['content']); ?></div>

        <?php print $feed_icons; ?>

      </<?php print $tag; ?>>

There is also a bit of extra CSS that should have been committed, for navigation.css this slots in around line 223:

/* tasks */
div#tasks {
  margin-top: 20px;
  margin-bottom: 10px;
  padding: 0;
}
.not-front.page-node div#tasks {
  margin-top: 0;
}

and in page css we need to add div#tasks to the very first declaration in that file, i.e.

.block-inner,
.breadcrumb,
.region-help,
.messages,
#main-content > header,
div#tasks,
#attribution {
    margin-left: 20px;
    margin-right: 20px;
}

I have committed these fixes to the dev version, so they will show when that is rebuilt (every 12 hours or so), I want to test this just a fraction more, if OK I will release a new version because this is a really bad miss and I too cannot believe no one else has reported it!

I'm seeing the same thing on a site I'm developing. Keep us posted :)

Is this fixed in the stable version?

not fixed in the stable version.

Hi Jeff,

Has this issue been fixed in v7.x-2.2 as I'm still getting duplicate titles on articles and polls with Drupal 7.9 and AT Core 7.x-2.1.
I've updated the code as detailed above but no luck. Any idea? This does not happen with newly created custom content types.

Thank in advance,
JS

#3 fixed the issue for me...

It should be fixed in the DEV version, I will be cutting new releases for the themes with updates at the end of this week.

And you are right... It does after all when I load the right copy of the theme... My bad...
Thanks for replying...
JS

Thanks for the update Jeff and sorry for the trouble... Great theme... Will be waiting for next release...
Thanks again, JS

#3 worked for us too on http://www.cybermidnight.com Thanks Jeff!