First, thx for the great work!! I've found one bug, which was an easy fix.

When I installed 5.x-1.x-dev I had no errors, but attached files were still ignored as if mmb wasn't there.

I traced the problem to line 79 of mmb.module. For my setup (PHP5, drupal 5.1) $structure stores the filename attribute as 'FILENAME', not 'filename'. So I changed:

if ($structure->dparameters[0]->attribute == 'filename' AND ....

to

if (strtolower($structure->dparameters[0]->attribute) == 'filename' AND ....

I noticed a few other places in the code where you use strtolower(), and that seemed more general than changing 'filename' to 'FILENAME'.

Really great module! Thx a bunch.

Comments

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Version: 5.x-1.x-dev » master
Assigned: Unassigned » sanduhrs
Status: Active » Closed (fixed)

Those values in $structure->dparameters seem vary. Probably dependent on the used Mailclient.
Commited a patch a minute ago.
Thanks.

cvining’s picture

cvining commented

Great! I can appreciate that. I'm using a VPS with ubuntu 6.06 & postfix, if that helps at all.

Again, thx a bunch for the module.