If you login using FB connect, and then turn off javascript and log out of Drupal, you are redirected to logout of Facebook first, but never actually logged out of Drupal. This is because D7 changed the order of things in the user_logout function:

http://api.drupal.org/api/drupal/modules--user--user.pages.inc/function/...
http://api.drupal.org/api/drupal/modules--user--user.pages.inc/function/...

CommentFileSizeAuthor
#1 fb-1308330-logout-js.patch481 bytesSteven Jones
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Active » Needs review
FileSize
fb-1308330-logout-js.patch481 bytes

And here's a patch.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Needs review » Reviewed & tested by the community

This patch works for me

Dave Cohen’s picture

Dave Cohen CreditAttribution: Dave Cohen commented
Status: Reviewed & tested by the community » Closed (won't fix)

Cleaning issue queue.

I don't recall exactly when, but that hook_user_logout is actually no longer used. I removed it with a comment about "causing problems" but sadly can't remember exactly what I was referring to. D'oh!

I know this is an old issue, but if you test logout again without javascript I'd be interested to know if it works. I think its a rare case to enable javascript temporarily then disable it. Right?