Hi!

I created new project called BgndGallery. This module give you possibility to create powerful background (body or another HTML elements) slideshows with images from node's imagefield or nodereference gallery. Slideshow using Matteo Bicocchi's jquery.mb.bgndGallery.
As far as I know - there's no modules to implement this slideshow. Earlier I implemented this feature on themes, but there's a lot of problems. For example implementing on specific pages, lazy loading (I mean loading on page where I want it actually using), specific slideshows etc.
This module inspired and reworked from Galleria module approach. It's using optionsets, which you can create for different node types.

Project page: http://drupal.org/sandbox/beilinson/1308596
Git repo: http://drupalcode.org/sandbox/beilinson/1308596.git

This module created for Drupal 7.x

Thanks,
Daniel.

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
  • git release branch missing, see http://drupal.org/node/1015226
  • lines in README.txt should not exceed 80 characters
  • only list files in the info file that contain classes or interfaces
  • bgndgallery_add_css(): indentation error, always use 2 spaces. Also in bgndgallery_page_optionset_list(), please run coder to check your code style http://drupal.org/project/coder
  • "'raster' => '/sites/all/libraries/bgndgallery/inc/raster.png'": that path is hardcoded, I guess it does not work if you have bgndgallery in /sites/example.com/libraries/bgndgallery?
  • bgndgallery_option_element(): always use "{}" around "if" statements, even if they are just one liners.
  • bgndgallery.css: indentation errors, always use 2 spaces. See the CSS coding standards http://drupal.org/node/302199
Daniel A. Beilinson’s picture

Daniel A. Beilinson commented
Status: Needs work » Needs review

Thank you!
Please see http://drupalcode.org/sandbox/beilinson/1308596.git/shortlog/refs/heads/...

attiks’s picture

attiks commented
coder on minor
I noticed some very small code style issues. Please run the Coder module on "minor" setting to help catch these. The coding standards have even more information in this area. I noticed things like ...

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

Severity minor, Drupal Coding Standards
sites/all/modules/bgndgallery/bgndgallery.module:
 +196: [minor] There should be no trailing spaces
sites/all/modules/bgndgallery/theme/theme.inc:
 +5: [minor] There should be no trailing spaces
 +36: [minor] Use an indent of 2 spaces, with no tabs
 +39: [minor] Use an indent of 2 spaces, with no tabs
 +42: [minor] There should be no trailing spaces

Severity minor, Drupal Commenting Standards
sites/all/modules/bgndgallery/includes/bgndgallery.admin.inc:
 +221: [minor] indent secondary line of comment one space
 +251: [minor] indent secondary line of comment one space
sites/all/modules/bgndgallery/theme/bgndgallery-container.tpl.php:
 +5: [minor] indent secondary line of comment one space
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
attiks’s picture

attiks commented

you need to create a branch for 7.x-1.x and delete the 7.x-1.0 branch

kvoltz’s picture

kvoltz commented

I would love to test this module, but I can't seem to download any of the commits. Any idea whats going on there?

misc’s picture

misc commented

@Daniel A. Beilinson has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

misc’s picture

misc commented
Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact