Webform as block not staying on page after validation errors

I have the same problem.

Same issue.

Thanks for the code. I have tried it but it doesn't seem to work for me. I have verified that the custom submit handler is getting added to end end of the '#submit' array but it is not being called for some reason. It appears that the submit handler is simply being ignored and the webform page gets loaded instead of the block the same as before. Any idea what could be wrong?

// Add our custom submit handler LAST so that Webforms doesn't overwrite it with its redirect behaviors
      array_push($form['#submit'], 'ccc_custom_code_webform_redirect_override');

I have the same problem and also for the confirmation page

Sure, thanks for offering to assist.

The complete code is below. I have tested and verified that the form ID is correct and that the new submit handler is being added to #submit as expected but the submit handler function is not being called.

function ccc_custom_code_form_alter(&$form, &$form_state, $form_id) {
  
  switch ($form_id) {
    case 'webform_client_form_8':
      
      if (!empty($form['#parameters'][1]['post'][REDIRECT_OVERRIDE])) {
        $redirect_override = $form['#parameters'][1]['post'][REDIRECT_OVERRIDE]; 
      } 
      else {
        // Note we're tacking on a query arg for GA trackability - not required
        $redirect_override = serialize(array(('node/' . arg(1)), 'form=' . $form_id));
      }
      
      // Set a hidden field for the parent node and add submit handler to handle redirect
      if (empty($form_state['values'][REDIRECT_OVERRIDE])) {
        $form[REDIRECT_OVERRIDE] = array(
          '#type' => 'hidden',
          '#value' => $redirect_override,
        );
      }

      // Add our custom submit handler LAST so that Webforms doesn't overwrite it with its redirect behaviors
      array_push($form['#submit'], 'ccc_custom_code_webform_redirect_override');
      
      break;
  }
} 


function ccc_custom_code_webform_redirect_override($form, &$form_state) {
  
  if (!empty($form_state['values'][REDIRECT_OVERRIDE])) {
    $form_state['redirect'] = unserialize($form_state['values'][REDIRECT_OVERRIDE]);
  }
}

Thanks for your help with this. I really appreciate it! You were correct in pointing out the constants, I had not defined them. I replace the constant with the string, "redirect_override", but am still having the same issue. The submit handler is not being called even though the callback appears to get added to submit correctly. See snippet:

  [#submit] => Array
        (
            [0] => webform_client_form_pages
            [1] => webform_client_form_submit
            [2] => ccc_custom_code_webform_redirect_override
        )

However, when I place a watchdog() function at the top of the submit callback, I see that it is never called. I have looked over the code and flushed the caches and have no idea why ccc_custom_code_webform_redirect_override() never gets called.

Any ideas what would cause this?

Complete Module

function ccc_custom_code_form_alter(&$form, &$form_state, $form_id) {
  
  switch ($form_id) {
    case 'webform_client_form_8':
      
      if (!empty($form['#parameters'][1]['post']['redirect_override'])) {
        $redirect_override = $form['#parameters'][1]['post']['redirect_override']; 
      } 
      else {
        // Note we're tacking on a query arg for GA trackability - not required
        $redirect_override = serialize(array(('node/' . arg(1)), 'form=' . $form_id));
      }
      
      // Set a hidden field for the parent node and add submit handler to handle redirect
      if (empty($form_state['values']['redirect_override'])) {
        $form['redirect_override'] = array(
          '#type' => 'hidden',
          '#value' => $redirect_override,
        );
      }

      // Add our custom submit handler LAST so that Webforms doesn't overwrite it with its redirect behaviors
      array_push($form['#submit'], 'ccc_custom_code_webform_redirect_override');      
      
      break;
  }
} 


function ccc_custom_code_webform_redirect_override($form, &$form_state) {
   watchdog('test','okay');
  if (!empty($form_state['values']['redirect_override'])) {
    $form_state['redirect'] = unserialize($form_state['values']['redirect_override']);
  }
}

Thanks for that code. I've managed to get a working custom module for my code, but mine is Drupal 7. It's very similar to your code, but with the D7 changes. I don't know if it would work in a subdirectory, but that should be a very easy fix. If we could just get these changes built into the module, setfree might not have to worry about it. I took a look at his code and nothing seemed immediately wrong.

Drupal 7 Module:
CUSTOM_MODULE: Name of your custom module
WEBFORM_FORM_ID: id of the Webform

function CUSTOM_MODULE_form_alter(&$form, &$form_state, $form_id) {
  switch ($form_id) {
    // Custom redirection for any webforms you choose
    case 'WEBFORM_FORM_ID':
      // Set a hidden field for the parent node and add submit handler to handle redirect
      if (empty($form_state['values']['redirect_override'])) {
        // The redirect needs a normal path
        $form['redirect_override'] = array(
          '#type' => 'hidden',
          '#value' => serialize($_GET['q']),
        );
        // But the action needs a url() path if errors happen
        $form['#action'] = _CUSTOM_MODULE_get_current_path();
      }
      // Add our custom submit handler LAST so that Webforms doesn't overwrite it with its redirect behaviors
      array_push($form['#submit'], '_CUSTOM_MODULE_webform_redirect_override');
     
      break;
  }
}

// Custom redirect submission for Webforms
function _CUSTOM_MODULE_webform_redirect_override($form, &$form_state) {
  if (!empty($form_state['values']['redirect_override'])) {
    $form_state['redirect'] = array(unserialize($form_state['values']['redirect_override']));
  }
}

// Get the proper path for the current page
function _CUSTOM_MODULE_get_current_path() {
  $url = drupal_lookup_path('alias', $_GET['q']);
  if (empty($url)) {
    $url = $_GET['q'];
  }
  // Front-page url should be empty
  if ($url == "front") {
    $url = "";
  }
  $url = url($url);
  return $url;
}

@BillyMG Just FYI, your code works fine on D6. Thanks! :)

@BillyMG, worked perfect on my D6 install too! Thanks :)

This is actually a bug in Webform. Separately reported over here: #1337784: Selecting "No redirect" does not reload current page..

@BillyMG: works fine on D7... thanks :-)

@BillyMG: can u tell me where to implement this code? I'm relatively new to Drupal (and most definitely to php).

I couldn't get this to work on D7 - probably through my own mistake.

A nice little fix for this is to use the clientside validation module - keeps the validation errors on the same page even if in a block, in a panel or wherever, and puts them next to the form.

Joe

Okay, thanks! I'll certainly read that information.
In the meanwhile I solved the problem using client side validation.

For drupal 6 and webform 3.17 the #11 works indeed perfectly - Thanks a lot @BillyMG !

Little modification for my personnal case: I wanted that the error page reloads on the current page where I have my form in a block, but I wanted the confirmation page to follow the redirection I set in the webform redirection location. For that, I just had to not call the redirect_override in the form submit but only the get_current_path in the form action.
So for my purpose the module is then :

<?php
function tmc_patch_webform_form_alter(&$form, &$form_state, $form_id) {

  switch ($form_id) {
    // Custom redirection for any webforms you choose
    case 'webform_client_form_164':
      // Set a hidden field for the parent node and add submit handler to handle redirect
      if (empty($form_state['values']['redirect_override'])) {
        // The redirect needs a normal path
        $form['redirect_override'] = array(
          '#type' => 'hidden',
          '#value' => serialize($_GET['q']),
        );
        // But the action needs a url() path if errors happen
        $form['#action'] = _tmc_patch_webform_get_current_path();
      }
     
      break;
  }
}

// Get the proper path for the current page
function _tmc_patch_webform_get_current_path() {
  $url = drupal_lookup_path('alias', $_GET['q']);
  if (empty($url)) {
    $url = $_GET['q'];
  }
  // Front-page url should be empty
  if ($url == "front") {
    $url = "";
  }
  $url = url($url);
  return $url;
}

?>

Hope it will help some :)
Liaz

Very simple,
go to admin/block edit your webform block and check "Show all webform pages in block" and all errors display in block not in node.
Regards

Cool!

@banense nice and simple way to fix this! Thanks for share. Regards.

There it is!! Thanks.

Nice trick banense, also works in D7 !

This checkbox description should be more explicit I think...

#11 works for me in D7.18 and webform 7.x-3.18.

Thank you!

But the same functionality is achieved with #22. No need to create a custom block.

#22 works great for me as well.

For a code solution that does this for all webform blocks, we used this snippet (D7) inside a hook_form_alter, it's a little simpler than #11. The redirect for success will inherit the settings setup in the webform.

//inside hook_form_alter...

//If we have a webform block, make it submit on the page we're on
if (!empty($form['#node']->webform_block)) {
  //Set the action to blank string so form API fills in default of the current page
  $form['#action'] = '';
}

hey everyone i am a newbie to drupal i am from Jamaica and i am having the same problem here but so for in my studies i only know Html and Css so this PHP stuff i am kinda clue less... wish i had a tooter

#22 did it for me. Thanks!

Legend banese! (#22) I thought it might be nice to know that a little answer you posted a year ago is still of use to someone!

I had overlooked that checkbox in my webform block configuration.

Solved the 'redirects to the webform node' on validation error, along with another issue I was having with passing info about the node with the webform embedded in it.

On that note, it must be time for lunch. :)

Cheers, Jules

#22 is working fine and was able to fix this issue up.

Banense you are a legend.
That was a really great solution, exactly what i was looking for.

Client Side Validation worked great to fix this problem for me.

#22 works for me too. thanks

#22 thumbs up.

Related issue on 7.x-4 with patch:
#2158261: Webform block redirects to page by default

#22 work for me also.

#22 @banense, Just Awesome

#22 is just perfect!

Added #22 to the following documentation on Webform in a block.
https://www.drupal.org/node/1447436

Here is my code, VERSION: 7.x-3.20
Webform as block staying on page after validation errors and allow no redirect

function mymodule_form_alter (&$form, &$form_state, $form_id){
  switch ($form_id) {
      case 'webform_client_form_27':
      $form['#action'] = url(drupal_get_path_alias($_GET["q"]));
  }
}

#22 Solves the issue, thanks!

#22 save me after finding the checkbox on /admin/build/block/configure/webform/client-block-ID#block_settings