Actually both 7.x-1.x and 6.x-1.x

usermerge.module uses php short tag form to open <? rather than <?php which breaks on lots of systems (like mine :) also http://drupal.org/coding-standards#phptags Trivial patches to follow. Any chance of changing it. Cheers.

CommentFileSizeAuthor
#1 1308866-1.usermerge-7.php-tags.patch473 bytesekes
#1 1308866-1.usermerge-6.php-tags.patch519 bytesekes

Comments

ekes’s picture

ekes commented
StatusFileSize
new 1308866-1.usermerge-6.php-tags.patch519 bytes
new 1308866-1.usermerge-7.php-tags.patch473 bytes

Patches for 6 and 7.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Reviewed & tested by the community

Seems ready to me.

danchadwick’s picture

danchadwick commented

Agreed. Please commit.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

Now fixed - http://drupalcode.org/project/usermerge.git/commit/3464b7c and http://drupalcode.org/project/usermerge.git/commit/60c2537

Thanks, ekes!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 3464b7c on 7.x-1.x, 8.x-1.x, 7.x-2.x, 7.x-2.x-api authored by ekes, committed by greggles: 
    Issue #1308866 by ekes: PHP code tags