Don't render table header if all field labels are empty

I have the same problem, to fix it I add to the theme the attached file.
But I think hide blank table headers must be in the views core.

Please provide a real patch with proper codestyle.

The code changes in #1309026-1: Don't render table header if all field labels are empty work, but I think it'd be more appropriate to put that logic in the preprocess function (and marginally more efficient since the logic can be embedded in the existing loop through all fields).

The attached patch introduces a theme variable, header_empty, that's set to TRUE if all labels are empty strings and FALSE otherwise. The template can simply check this variable before creating the thead element.

We're actually not rendering or omitting the thead element, rather than just hiding it.

My patch in #1309026-4: Don't render table header if all field labels are empty is actually made against 7.x-3.0-rc3.

I made a simpler patch (against 7.3-3.x-dev) which should solves this, without introducing a new variable. Aditionnally, it makes the notices and warnings disappear.

removed the tag, (thought it was a title field for the comment)

+++ b/theme/views-view-table.tpl.phpundefined
@@ -21,6 +21,7 @@
   <thead>
     <tr>
       <?php foreach ($header as $field => $label): ?>
@@ -30,6 +31,7 @@

@@ -30,6 +31,7 @@
       <?php endforeach; ?>
     </tr>
   </thead>

Please add some intentation

Tnx for the quick review! Added some indentation.

Great looks perfect now, so committed to 7.x-3.x

It's probably helpful to backport this change

Voila .. backported to 6.x-3.x.

Thanks! Committed to 6.x-3.x

I think the point of doing it as a tpl.php was not to have to use a patch. Personally, I prefer that approach.

Checked 7.x-3.2 and it doesn't work. Views still render table header with empty cells because $header variable is not empty even when all labels are disabled. Quick fix is to check filtered header array instead of original.

+++ b/theme/views-view-table.tpl.phpundefined
@@ -21,7 +21,7 @@
+  <?php if (array_filter($header)) : ?>

It would be probably better to run array_filter in the preprocess code

Yes, you're right.

+++ b/theme/theme.incundefined
@@ -605,6 +605,11 @@ function template_preprocess_views_view_table(&$vars) {
+  // Hide table header if all labels are empty.
+  if (!array_filter($vars['header'])) {
+    $vars['header'] = array();

Even this might be hard to believe but i fear that people actually expect that a table with empty headers still appear. Maybe a settings should be used instead, but i'm not 100% sure about that.

If there are no labels, there certainly should be no header. That's why this is a bug report. :)

I've reviewed the patch and it works perfectly, thanks for the work on this!

Some time ago i made some experience with people when some new css classes got added.

But sure i can refer to this issue if someone complains :p

Thanks, I can confirm as well that Views 7 dev version works :)

Port to 6.x-3.x. Also prevents colspan="0" on empty text cell.

Also, attaching patch for 7.x-3.x with the fix for appearing colspan="0".

Fixes go to current dev (7.x in this case) before being applied to 6.x. This patch combines #18 and #25. Please test and rtbc.

Argh. I'm not working on my normal computer... try this one bot!

#18 has been already committed, so just use #25 for 7.x-3.x to apply fix for colspan="0".

The 6 year old patch in #29 does not apply to the latest views 7.x-3.x-dev and if still applicable needs a reroll.

Checking patch theme/theme.inc...
error: while searching for:
  $vars['classes_array'] = array('views-table');
  if (empty($vars['rows']) && !empty($options['empty_table'])) {
    $vars['rows'][0][0] = $view->display_handler->render_area('empty');
    // Calculate the amounts of rows with output.
    $vars['field_attributes'][0][0]['colspan'] = count($vars['header']);
    $vars['field_classes'][0][0] = 'views-empty';
  }

error: patch failed: theme/theme.inc:637
error: theme/theme.inc: patch does not apply

Patch rerolled.

Patch rerolled/fixed after last commits.