The kitchen sink (remove notices, fix bugs, enhance code styling)

Reroll for taxonomy.

The change to install.php has already been applied to head.

Other than that, it seems to work fine. I've logged in, created a couple of users, logged in as them, created some content, enabled path, modified the content. Posted comments etc. If you're interested, there's still some e_notice warnings:

• enable search module, search for empty string
  notice: Undefined variable: keys in /home/simon/src/drupal-cvs/drupal/modules/search/search.module on line 936.
  (wierd behaviour with above: search for ' ' (space), shows warning, click search without typeing anything in the edit field, shows warning again. click search without typing anything, no notice - what's different)
• /admin/build/block lots of warnings
  # notice: Undefined index: visibility in /home/simon/src/drupal-cvs/drupal/modules/block/block.module on line 194.
  # notice: Undefined index: throttle in /home/simon/src/drupal-cvs/drupal/modules/block/block.module on line 194.
• [Mon Mar 26 10:08:47 2007] [error] [client 127.0.0.1] PHP Warning: Table 'watchdog' was not locked with LOCK TABLES\nquery: INSERT INTO watchdog (uid, type, message, severity, link, location, referer, hostname, timestamp) VALUES (1, 'php', '<em>Undefined index: throttle</em> in <em>/home/simon/src/drupal-cvs/drupal/modules/block/block.module</em> on line <em>194</em>.', 2, '', 'http://localhost/head/admin/build/block', 'http://localhost/head/admin', '127.0.0.1', 1174867727) in /home/simon/src/drupal-cvs/drupal/includes/database.mysql.inc on line 172, referer: http://localhost/head/admin

These seem too minor to raise as seperate defects?

More!

This time without parse error...

Rerolled against HEAD.

-

Props to Bobbi Anderson and webchick -- they found all the notices. I just fixed them. I do not intend to add anything more. THere will be bug reports filed for the bugs webchick found because they are not minor enough to pour into this.

Committed to HEAD. Thanks a bunch.