As the title says. I walked HEAD and fixed this and that.

CommentFileSizeAuthor
#8 kitchensink_5.patch61.9 KBchx
#7 kitchensink_4.patch47.29 KBchx
#6 kitchensink_3.patch46.15 KBchx
#5 kitchensink_2.patch37.86 KBchx
#4 kitchensink_1.patch37.86 KBchx
#1 kitchensink_0.patch23.3 KBchx
kitchensink.patch23.5 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new kitchensink_0.patch23.3 KB

Reroll for taxonomy.

lyricnz’s picture

lyricnz commented

The change to install.php has already been applied to head.

lyricnz’s picture

lyricnz commented

Other than that, it seems to work fine. I've logged in, created a couple of users, logged in as them, created some content, enabled path, modified the content. Posted comments etc. If you're interested, there's still some e_notice warnings:

  • enable search module, search for empty string
    notice: Undefined variable: keys in /home/simon/src/drupal-cvs/drupal/modules/search/search.module on line 936.
    (wierd behaviour with above: search for ' ' (space), shows warning, click search without typeing anything in the edit field, shows warning again. click search without typing anything, no notice - what's different)
  • /admin/build/block lots of warnings
    # notice: Undefined index: visibility in /home/simon/src/drupal-cvs/drupal/modules/block/block.module on line 194.
    # notice: Undefined index: throttle in /home/simon/src/drupal-cvs/drupal/modules/block/block.module on line 194.
  • [Mon Mar 26 10:08:47 2007] [error] [client 127.0.0.1] PHP Warning: Table 'watchdog' was not locked with LOCK TABLES\nquery: INSERT INTO watchdog (uid, type, message, severity, link, location, referer, hostname, timestamp) VALUES (1, 'php', '<em>Undefined index: throttle</em> in <em>/home/simon/src/drupal-cvs/drupal/modules/block/block.module</em> on line <em>194</em>.', 2, '', 'http://localhost/head/admin/build/block', 'http://localhost/head/admin', '127.0.0.1', 1174867727) in /home/simon/src/drupal-cvs/drupal/includes/database.mysql.inc on line 172, referer: http://localhost/head/admin

These seem too minor to raise as seperate defects?

chx’s picture

chx commented
StatusFileSize
new kitchensink_1.patch37.86 KB

More!

chx’s picture

chx commented
StatusFileSize
new kitchensink_2.patch37.86 KB

This time without parse error...

chx’s picture

chx commented
StatusFileSize
new kitchensink_3.patch46.15 KB

Rerolled against HEAD.

chx’s picture

chx commented
StatusFileSize
new kitchensink_4.patch47.29 KB

-

chx’s picture

chx commented
StatusFileSize
new kitchensink_5.patch61.9 KB

Props to Bobbi Anderson and webchick -- they found all the notices. I just fixed them. I do not intend to add anything more. THere will be bug reports filed for the bugs webchick found because they are not minor enough to pour into this.

Steven’s picture

Steven commented
Status: Needs review » Fixed

Committed to HEAD. Thanks a bunch.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)