Download & Extend
Issues

The kitchen sink (remove notices, fix bugs, enhance code styling)

Posted by chx on March 25, 2007 at 7:41pm
Project:Drupal core
Version:6.x-dev
Component:base system
Category:bug report
Priority:normal
Assigned:chx
Status:closed (fixed)

Issue Summary

As the title says. I walked HEAD and fixed this and that.

AttachmentSizeStatusTest resultOperations
kitchensink.patch23.5 KBIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by chx on March 25, 2007 at 8:13pm

Reroll for taxonomy.

AttachmentSizeStatusTest resultOperations
kitchensink_0.patch23.3 KBIgnored: Check issue status.NoneNone

#2

Posted by lyricnz on March 25, 2007 at 11:48pm

The change to install.php has already been applied to head.

#3

Posted by lyricnz on March 26, 2007 at 12:11am

Other than that, it seems to work fine. I've logged in, created a couple of users, logged in as them, created some content, enabled path, modified the content. Posted comments etc. If you're interested, there's still some e_notice warnings:

  • enable search module, search for empty string
    notice: Undefined variable: keys in /home/simon/src/drupal-cvs/drupal/modules/search/search.module on line 936.
    (wierd behaviour with above: search for ' ' (space), shows warning, click search without typeing anything in the edit field, shows warning again. click search without typing anything, no notice - what's different)
  • /admin/build/block lots of warnings
    # notice: Undefined index: visibility in /home/simon/src/drupal-cvs/drupal/modules/block/block.module on line 194.
    # notice: Undefined index: throttle in /home/simon/src/drupal-cvs/drupal/modules/block/block.module on line 194.
  • [Mon Mar 26 10:08:47 2007] [error] [client 127.0.0.1] PHP Warning: Table 'watchdog' was not locked with LOCK TABLES\nquery: INSERT INTO watchdog (uid, type, message, severity, link, location, referer, hostname, timestamp) VALUES (1, 'php', '<em>Undefined index: throttle</em> in <em>/home/simon/src/drupal-cvs/drupal/modules/block/block.module</em> on line <em>194</em>.', 2, '', 'http://localhost/head/admin/build/block', 'http://localhost/head/admin', '127.0.0.1', 1174867727) in /home/simon/src/drupal-cvs/drupal/includes/database.mysql.inc on line 172, referer: http://localhost/head/admin

These seem too minor to raise as seperate defects?

#4

Posted by chx on March 26, 2007 at 12:21am

More!

AttachmentSizeStatusTest resultOperations
kitchensink_1.patch37.86 KBIgnored: Check issue status.NoneNone

#5

Posted by chx on March 26, 2007 at 12:22am

This time without parse error...

AttachmentSizeStatusTest resultOperations
kitchensink_2.patch37.86 KBIgnored: Check issue status.NoneNone

#6

Posted by chx on March 26, 2007 at 6:00am

Rerolled against HEAD.

AttachmentSizeStatusTest resultOperations
kitchensink_3.patch46.15 KBIgnored: Check issue status.NoneNone

#7

Posted by chx on March 26, 2007 at 7:09am

-

AttachmentSizeStatusTest resultOperations
kitchensink_4.patch47.29 KBIgnored: Check issue status.NoneNone

#8

Posted by chx on March 26, 2007 at 5:00pm

Props to Bobbi Anderson and webchick -- they found all the notices. I just fixed them. I do not intend to add anything more. THere will be bug reports filed for the bugs webchick found because they are not minor enough to pour into this.

AttachmentSizeStatusTest resultOperations
kitchensink_5.patch61.9 KBIgnored: Check issue status.NoneNone

#9

Posted by Steven on March 27, 2007 at 5:14am
Status:needs review» fixed

Committed to HEAD. Thanks a bunch.

#10

Posted by Anonymous on April 10, 2007 at 5:15am
Status:fixed» closed (fixed)
nobody click here