I get the following error after submitting a og contact form.

Warning: Invalid argument supplied for foreach() in og_contact_get_recipients() (line 194 of /sites/all/modules/og_contact/og_contact.pages.inc).

I believe line 194 needs altering to foreach ($admin_query as $admin) {

Is anyone else getting this?

CommentFileSizeAuthor
#1 swapping_for_each_argument-1309802-1.patch609 bytesmd2

Comments

md2’s picture

md2 commented
StatusFileSize
new swapping_for_each_argument-1309802-1.patch609 bytes

The following patch seems to fix the issue by correcting the order of the foreach arguments.

gnat’s picture

gnat commented
Status: Active » Needs work

Thanks for the report and the patch!

I'm setting this to "needs work" not because your patch doesn't fix the bug, but because bc was working on a larger patch set and rewrite of that function. I'm going to see where they are with that, and see if I can get that into the module.

If I don't hear back soonish, I'll roll this into next -dev release.

md2’s picture

md2 commented

Yes no worries, its a stupidly small patch anyhows :)

bassthiam’s picture

bassthiam commented

Hello there,
i bumped on this issue while searching for a og mass_contact module.
@gnat we still waiting for bc's lager patch & i'm wondering why since 2011 nobody there are no more comments on this page.

Subscribing,
but i think that it will be great if we can have a look at bc's work and try to continue with.

greg.1.anderson’s picture

greg.1.anderson commented
Status: Needs work » Fixed

This is fixed in the current 7.x-1.x-dev.

greg.1.anderson’s picture

greg.1.anderson commented
Status: Fixed » Needs work

My mistake; this is fixed by the patch in #1701418: Support for OG 7.x-2.x. This could be closed as a duplicate, though, I think.