This code creates a styled section beneath a new book:

<div class="book"><div class="nav"> <div class="links"><div class="prev">&nbsp;</div><div class="next">&nbsp;</div></div> <div class="titles"></div></div></div>  </div>

If there is no data to be displayed, empty divs should not be output.

CommentFileSizeAuthor
#3 book.module_8.patch3.06 KBcrunchywelch
#2 book.module_7.patch7.89 KBcrunchywelch
book_divs.png9.83 KBchrismessina

Comments

robin monks’s picture

robin monks commented

The <div class="book"><div class="nav"> <div class="links"><div class="prev">&nbsp;</div><div class="next">&nbsp;</div></div> <div class="titles"></div></div></div></div> still exists. Bumping up to HEAD.

Robin

crunchywelch’s picture

crunchywelch commented
Status: Active » Needs review
StatusFileSize
new book.module_7.patch7.89 KB

Here is a patch that fixes this, it rearranges the theme_book_navigation function logic to only output the navigation book div if there is content to display.

crunchywelch’s picture

crunchywelch commented
StatusFileSize
new book.module_8.patch3.06 KB

Seems I tried to sneak in my timezone system.module patch as well ;). Here is a patch without the system.module diff.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Needs work

doesn't apply anymore.

beginner’s picture

beginner commented
Version: » 4.6.6
Priority: Normal » Minor
Status: Needs work » Fixed

This seems to be fixed in HEAD and it seems in 4.7, too.

Does the 4.6 accept minor bugs like this one?

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)