The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Breadcrumb, help and tree are now fixed on 40x pages. Most (but not all) bugs were due to the shortcut for the access checking which in itself was a bit broken: only visible parents are access checked and we happily inherited from nonvisible
elements. In a weird tree configuration this could have lead to skipping access checking -- core does not have such weirdness.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | menu_103.patch | 23.61 KB | chx |
| #8 | menu_102.patch | 22.28 KB | chx |
| #7 | menu_101.patch | 22.29 KB | chx |
| #6 | menu_100.patch | 22.28 KB | chx |
| #4 | menu_96.patch | 3.62 KB | chx |
Comments
Comment #1
chx commentedTo test this patch, pick a 404 and a 403 page in HEAD -- the 403 page should be a tab -- observe what you see -- apply patch -- observe again and report.
Comment #2
dmitrig01 commented404 - menu system errors gone, but garland page.tpl.php errors remain.
403:
before:
'access denied' but there are tabs (by task, by module), and in the sidebar (nav menu) there is a logs menu item.
All testing done with a fresh install, and I haven't even created a user. When I click on logs, the menu expands to show the correct items.
after:
works as expected
Comment #3
webernet commentedPatch fixes the issue with tabs and menu items appearing when they shouldn't.
Comment #4
chx commentedI fixed the trail as well. This greatly simplifies matters.
Comment #5
webernet commentedComment #6
chx commentedAside from bugfixes, I renamed menu_edit to menu_custom because it holds new items as well (we discussed with Steven) and changed the menu definition in system -- I consider the menu table structures now complete. Let's hope nothing arises. I wanted to include an upgrade path, In some sense, it's trivial, because menu_custom and the old menu table holds almost the same fields. The lack of the 'parent' field however, is a big, big problem. I will consult the powers that be how shall we proceed in this regard.
Comment #7
chx commentedRerolled to HEAD
Comment #8
chx commentedNow...
Comment #9
chx commentedBetter..
Comment #10
dmitrig01 commentedEverything worked. I played around with parenting, that worked. I set a link to drupal.org, that worked. The only thing is that on a menu item edit page, the admin menu is not expanded (see my screenshot
Comment #11
dmitrig01 commented:-)
Comment #12
chx commentedThanks. That problem is a totally different bug which will need attention down the line, but it's so minor that even if I can't get it fixed before the freeze I won't lose sleep.
Comment #13
dries commentedCommitted to CVS HEAD. Thanks! :)
Comment #14
(not verified) commented