by phantom, i mean not listed in admin > menu and not listed in the menu table.
to get rid of the phantom menu item i commented out the following in the feedback_menu function.

   /* $items[] = array (
      'path' => 'feedback',
      'title' => t('Feedback'),
      'callback' => 'feedback_mail_page',
      'access' => user_access('can send feedback'),
      'type' => MENU_NORMAL_ITEM,
    );*/

would this solve the problem without having to comment out?

    $items[] = array(
      'path' => 'feedback',
      'title' => variable_get('feedback_page_title', t('Feedback)),
      'callback' => 'drupal_get_form',
      'callback arguments' => 'feedback_mail_page',
      'access' => user_access('send invitations'),
      'type' => MENU_NORMAL_ITEM);
CommentFileSizeAuthor
#7 feedback_menu.patch391 bytesdavemybes

Comments

dsp1’s picture

dsp1 commented

that did not fix it, just broke feedback. does anyone know how to get rid of the phantom menu item?

kbahey’s picture

kbahey commented
Status: Active » Needs work

Please submit this as a proper patch. See http://drupal.org/patch for details.

dsp1’s picture

dsp1 commented

but it is not a patch. i am asking how to get rid of the phantom Feedback showing on Nav.

kbahey’s picture

kbahey commented
Status: Needs work » Active

Try replacing MENU_NORMAL_ITEM with MENU_SUGGESTED_ITEM, and see if that does what you want.

If it does, then submit it as a patch.

dsp1’s picture

dsp1 commented

yes that fixed it. thanks.
i know how to apply a patch, but don't know how to make a patch.

kbahey’s picture

kbahey commented
Status: Active » Needs work

Please create a patch then.

davemybes’s picture

davemybes commented
Status: Needs work » Needs review
StatusFileSize
new feedback_menu.patch391 bytes

Try this patch

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Development on Feedback module v1.x has ended. Beginning from 2.x, the Feedback module has been replaced with a completely different module with a different purpose. Please note that Feedback 2.x is not compatible with 1.x. See #279636: Turn Feedback into user feedback module for further information.

There will be a final 5.x-1.1 release with all existing and tested patches in the issue queue applied. If you need the functionality of the Feedback 1.x module, the Contact module in Drupal core as well as the contributed Webform module are recommended replacements. However, there is no migration path to those modules.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to 5.x-1.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.