Dear Maintainers,

I have created a module that could be used to create custom holidays as nodes in drupal. These nodes will be available as a list item in country list. I have used 'OHM' key to register the list as a country.

1> A sandbox project has been created which could be accessed from here: http://drupal.org/sandbox/D34dMan/1309636

2> The project application is being reviewed here: http://drupal.org/node/1309746

So far i have tried to leverage the full features of your holiday manager module. Will you please let me know if you have any suggestions or comments about the project.

Thank you.

Comments

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Assigned: Unassigned » kfritsche

This idea sounds great. And I think this could be useful.
I looked over our code and found some bugs and also have an feature request, but i will post this separately in the OHM issue list, so that every one can keep track on it.

Also there are already two calendars implemented in storm_contrib, where the holidays are displayed.
One you can find on http://you-domain.de/storm/holidays/display , if you have stormperson_holidays actived (it shows the holidays of the persons (vacation) in a calendar and also the normal holidays)
The other on is on the timetracking statistic pages for a stormperson, if you have enabled stormtimetracking_extension and calendar.
Furthermore for the stormproject/task/ticket forms the holiday module disables holidays for pickup in the javascript date_popup. So is there really a need for a further calendar only for holidays?

d34dman’s picture

d34dman commented

"So is there really a need for a further calendar only for holidays?" the answer depends on how long it would take me to integrate calendar functionality into the module itself so it works out of the box.

The reason why i suggested litecal module was... its default calendar-list view provides a QUICKADD TYPE: (which is a node type). So i thought it would be a trivial setup and holiday manager which necessarily displays all the holidays in a calendar display and a user can add storm_ohm node using that quick add button against each date cells.

Its more like a temporary solution until i roll in proper GUI to manage all holidays.

d34dman’s picture

d34dman commented

Seems like the Storm Organization Holiday Manager could not be fair to its name unless it DOES manage the holidays. That means it will have to take care of,

1> Adding and deleting custom holiday's (done by storm_ohm).
2> Enabling and disabling of holidays ( being done by storm contrib).
3> Managing different country holidays ( being done by storm contrib).

As you can see point 2 and point 3 makes storm contrib the actual holiday manager.

I would like to know storm_contrib maintainer's view on these two possibility, and suggest if any other possibility if they do feel so.

1.a> Change storm_ohm to something like storm_holidays_extra.
1.b> Merge storm_holidays_extra into storm_contrib.

2.a>Merge storm_ohm and storm_holiday.
2.b>storm_holiday stays inside storm_contrib?