When using the inline diff, the ajax call works, but the output isn't rendered as the ajax wrapper doesn't exist.

CommentFileSizeAuthor
#1 diff-1310422-fix-inline.patch1.21 KBskwashd

Comments

skwashd’s picture

skwashd commented
Status: Active » Needs review
StatusFileSize
new diff-1310422-fix-inline.patch1.21 KB

The attached patch fixes this problem.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

@skwashd,

Can you please explain this patch, or at least provide some reproduction details, as the change itself seems redundant as it's simply replacing one ID with another, unless there are other places where the new ID is being used, or if the first ID is being nuked somehow.

At a glance, the patch makes no sense to me, but I'm happy to be shown the error in my ways.

Cheers,
Deciphered.

skwashd’s picture

skwashd commented

The current element id for the ajax wrapper never exists in the page and so the request is made, the diff content is returned it is never injected back into the page as the target isn't there. This patch uses the standard Drupal node element id as the wrapper so it can be replaced by the ajax response.

alexh’s picture

alexh commented

The patch in #1 solves the problem. Thanks skwashd!

realityloop’s picture

realityloop commented
Status: Needs review » Fixed

commited, thanks skwashd

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.