so check this out, something happened and now my site looks like butt on certain pages.

OK so on my front page i want side blocks down the left hand side. ONLY on the front page do i want this.

on alll other pages i want the maximum width of the sheet to be allocated.





it USED to be this way. something happened and i really have no idea what!

i hope it's not a theme issue. i haven't messed with my theme lately, but i also haven't messed with any admin settings to change the layout.

regardless, i want to check my admin layout settings but now i cant find out where they're at. if someone can help me map it out, i would appreciate it.

Comments

awesome_cricket’s picture

just a friendly bump to see if anyones awake.

awesome_cricket’s picture

anyone out there? if you want to see what im talking about, please visit: http://olliesworld.tk/




note the front page has side content, this is fine.





click any other link, the guestbook for example. there is no side content, which is what i want - but now i still have the side content area showing up! it was not like this before, and i cant figure out what the F@#! happened! please, if you have any ideas, lend them. thank you.

awesome_cricket’s picture

has drupal recently within the last 32 hours, changed the theming engine again? stock themes still work fine with my site, but now my custom one is broken, which means something somewhere in the theme code is fucked up, and it neeever used to be! >:(

awesome_cricket’s picture

oh, come on already!

nevets’s picture

You might try validating your html, there is an unclosed div in there.

Also, looks fine in Firefox 7

awesome_cricket’s picture

thank you, i forgot about validators. i have ran the site and found likely what you found, but i don't know which file has the open tag.




accoriding to valid...w3.org,

Validation Output: 1 Error

Line 190, Column 9: end tag for "div" omitted, but OMITTAG NO was specified
[/body]

You may have neglected to close an element, or perhaps you meant to "self-close" an element, that is, ending it with "/]" instead of "]".

Line 60, Column 1: start tag was here
[div id="art-main"]




i have assumed to look in page.tpl of my theme in question. line 60 is merely a closed div tag, [/div] while line 190 is blank. 191 is a closed div tag, [/div]. as well, there is no instance of a closed body tag, [/body] anywhere in the code.

am i wrong in looking thru the page.tpl? here is my logic for going thru page.tpl, i know it is a theme issue & that page.tpl lays out or "draws," the site. if i edit out/remove the closed div tags, either both or one of them, the page looks worse, and the issue in chrome is not resolved.

awesome_cricket’s picture

done checking code for now, feel free to chime in as the problem is still there.

nevets’s picture

Given <div id="art-main"> is in page.tpl.php that is where I would start. Having an editor that can find closing tags helps. Or at least an editor that show how many matches a search produces so you could search for <div> and </div> and see if the count matches. Given the problem occurs on internal pages page.tpl.php is where I would start. If they are balanced there try node.tpl.php.

mcfilms’s picture

Also, I think it would have helped initially if you told what actions YOU took. Asking if Drupal changed it's theme engine didn't make sense to me at all when I read this last night. Regardless of what changes were made to Drupal core, how would they affect you? You would have needed to upgrade from one version to another.

Rather than focusing in on one suspect early on ("Drupal changed its theme engine"), I think you'd get more help if you stated what actions you took ("I was editing my tpl.php files" or "I updated Drupal core" and what the specific problem is, Stating "it looks like butt" doesn't really paint an accurate picture.

A list of some of the Drupal sites I have designed and/or developed can be viewed at motioncity.com

awesome_cricket’s picture

just for you, mcfilms. the last time i'll repeat myself for you.

so check this out, something happened and now my site looks like butt on certain pages.

OK so on my front page i want side blocks down the left hand side. ONLY on the front page do i want this.

on alll other pages i want the maximum width of the sheet to be allocated.

it USED to be this way. something happened and i really have no idea what!

i hope it's not a theme issue. i haven't messed with my theme lately, but i also haven't messed with any admin settings to change the layout.

hence i figured to ask if the theming engine has been changed, which could render aspects of a theme incompatible/broken. do you get it?





i can sense your obvious D.N'ism, i have provided quite accurately what the issue is, and what i have been doing in the meantime. i will appreciate you not thread-jacking and trying to start a war here. noone is leeching anything, i know what you're up to already and if you wish to debate me further, you should take it to my inbox or start a new thread in the general discussion forum.

mcfilms’s picture

Seriously my intent was to encourage clarity. I don't see how zero changes by you to your theme would lead to a problem. Drupal doesn't randomly change core files on you. I told you I had a problem "reading" you. Obviously my comments are unwelcome.

I'm done.

A list of some of the Drupal sites I have designed and/or developed can be viewed at motioncity.com

awesome_cricket’s picture

nevets, thanks for the input. i figured correctly then in going thru page.tpl, i appreciate you also concurring on that. i use Notepad++, I'll keep looking for open div tags and hope thats the issue. i still don't get where it came from, and when i use a backup of the theme, which worked well at one time, it too renders the same issues now, where as it used to work perfectly.

mcfilms’s picture

Maybe there's a chance for us to still be friends. I think I solved your issue.

Do you by any chance have some sort of block set in your "sidebar first" or "sidebar left" region for all pages? It looks like you added regions for the front page and maybe they are showing up on other pages.

The specific css that is causing the issue is in style.css line 832

.art-content-layout .art-layout-cell, .art-content-layout .art-layout-cell .art-content-layout .art-layout-cell {
    display: table-cell;
}

Okay, now I'm done.

A list of some of the Drupal sites I have designed and/or developed can be viewed at motioncity.com

awesome_cricket’s picture

i really do appreciate your assistence, i will look into what you propose. you caught me in the middle of a friendly email, actually. :)

awesome_cricket’s picture

well, after looking for the invalid div's and trying to make sense of the possible CSS issue, i wasn't able to cover any ground.

so what did i do? i tested the theme against an older test drupal i have sat on which has not been updated either automatically or by myself manually.





the theme works just fine in this older drupal in both firefox and most importantly for me, chrome.

this leads me to believe that either a module update or other drupal update which has taken place broke the way which my theme is processed by my live drupal (olliesworld.tk)

nevets’s picture

The div problem could be in content. Since Drupal does not update automatically, you would have recently had to apply an update.

awesome_cricket’s picture

right, it could have came from a recent module i added.. hmmm... what a mess.

hmmm......... statcounter, maybe...

awesome_cricket’s picture

HA! EUREKA!

for some reason, the statcounter module wants to insert itself in the left menu... disabling/removing statcounter has solved the problem. CRAP, now how can i run SC and not break my theme....

i want to thank you guys for your help on this. it's been fun!

open issue: http://drupal.org/node/1312644