Notice: Undefined index: q in current_path() (line 355 of includes/path.inc).

We have a function for this. :)

drupal_goto($destination, array('query' => drupal_get_query_parameters()));

I didn't test, but it looks good. Thanks!

http://drupalcode.org/project/bakery.git/commit/0f56d3b

I'm a little confused on what the intent of this code is. drupal_goto() automatically supports redirecting to $_GET['destination'] if it is set, so you don't need to manually pass and check it. Is the intent just to 'reload' the page for anonymous users if they get logged in?

Ack, drupal_get_query_parameters cannot be used since it lies in includes/common.inc which is not loaded when hook_boot() runs.

Hah, nevermind. I missed the drupal_bootstrap() call.

drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL); happens earlier in _bakery_taste_chocolatechip_cookie() if the cookie is valid, so drupal_get_query_parameters() should be available.

"Is the intent just to 'reload' the page for anonymous users if they get logged in?"

Yes.

Ok then this is the much simpler version of what you want for that code.

+++ b/bakery.moduleundefined
@@ -72,7 +72,7 @@ function bakery_menu() {
@@ -433,7 +433,6 @@ function _bakery_login_submit($form, &$form_state) {

@@ -433,7 +433,6 @@ function _bakery_login_submit($form, &$form_state) {
   }
   // Create cookie and redirect to master.
   bakery_bake_oatmeal_cookie($data['name'], $data);
-  unset($_REQUEST['destination']);
   unset($_GET['destination']);
   drupal_goto(variable_get('bakery_master', 'http://drupal.org/') . 'bakery/login');
 }

This line is removed because in D6, core used $_REQUEST['destination']. In D7, core and any modules should only be using $_GET['destination']. This is likely a porting error and since I was messing with destination stuff I fixed this too.

tl;dr drupal_goto() for D7 doesn't give a crap about $_REQUEST at all. It only cares about $_GET.

Won't this still run into the OP issue? That is that if anything calls current_path() before shutdown there will be an undefined index?

@glennpratt if you get a change to test this please report back here

No because we're no longer unsetting $_GET['q'].

Committed. Thanks! http://drupalcode.org/project/bakery.git/commit/832f974