Closed (fixed)
Project:
Advanced CSS/JS Aggregation
Version:
7.x-2.x-dev
Component:
Bundler
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Oct 2011 at 20:26 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mikeytown2 commentedFirst step is to bring the number of bundles from 4 down to 1. Taking hints from #1246816: Create workaround for jquery update ahah form bug when using node clone and a filefield loading jquery.js from googles cdn.
The next step is to change the rendering functions so it outputs inline code instead of link and script src tags.
$conf['advagg_css_render_function'] $conf['advagg_js_render_function']The step after that would be the use of some sort of output buffer to put the CSS code on the the actual HTML DOM elements.
Comment #2
doublejosh commentedStep #2 seems to be what emogrifier is all about.
Comment #3
mikeytown2 commentedThe final step (emogrifier) is about putting the styles on the actual div tags. For HTML this isn't necessary. Having the style tags in the header is all that's needed and AdvAgg can do this currently IF you create a render function to read the file contents. It's fairly trivial so I might create the module for fun. Config: A list of pages that get all local JS/CSS files inlined. Warn the user that this is a bad idea most of the time.
Comment #4
mikeytown2 commentedcommitted this patch, might make this a little easier to do.
Comment #5
mikeytown2 commentedSomething of interest: http://drupal.org/project/image_base64
Comment #6
mikeytown2 commentedSwitching to the 7.x-2.x branch.
#1171546-105: AdvAgg - D7 Port/Re-write
Comment #7
mikeytown2 commentedFound this
http://drupal.org/sandbox/dmitriytrt/1939698
Comment #8
mikeytown2 commentedThis patch has been committed.
If this is a major performance issue, I could use the more exotic hook hook_advagg_modify_js_pre_render_alter & hook_advagg_modify_css_pre_render_alter to accomplish the same thing.