Videos inserted via the WYSIWYG Editor do not load with JW Player once page is cached.

@Jarrod Thanks for the patch! I think the approach is right but there could be a few changes:

• This same problem manifests itself for blocks and anywhere else the text editor is used. For this reason the player JS can be added using hook_init so that all pages have it.
$variables['config'] holds all of the key-value pairs for the video. Loop through these values rather than hard-coding the keys to be added.
• Would it be possible to use drupal_add_js() with the inline option instead? I haven't looked at the output myself to see if this would be feasable, but it certainly feels cleaner and more "drupaly".
• No need for drupal_html_id() if you're just generating a hash anyhow.
• Try to conform to Drupal coding standards. For example, "}else{" should be separate lines with a space between "else" and "{".

@Jarrod Thanks for the updated patch. Sorry about my delay in responding. Attached is a slightly modified version to fix a few (minor) white space and capitalisation errors. An "interdiff" is attached as well to make it easy to see the changes since last time. To finish this off I'd like to see a few things:

• The creation of the inline JS should be done by a separate function to clean things up.
• Looking forward to adding plugins support, the options array will now include additional arrays. The code will need to adapt to suit.
• The UI to set the variable is required (as you know).
• The adding of the inline JS can be simplified. No need for three opening php tags when one will do.

Aside from these clean up issues things are looking good. Depending on time I may end up taking on some of this work.

Here's the patch applied to the latest commit

• Inline JS code has been routed through json_encode()
• Plugins support added in the above latest commit: #1338964: Support JW Player plugins
• UI to set the variable created as a general settings form in admin/config/media/jw_player/settings

I had forgotten to attach theme/jw_player.tpl.php.

Just noticed a bug with patch #8:

If a preset plugin is being used and then later turned off at a later date, the preset would still have the settings of the disabled plugin and would continue to output their setttings to the player in the javascript.

Attached patch with better checking of loading preset plugin settings based on only the available (module enabled) plugins.

Committed! Thanks Girish and Jarrod. I made a few small changes to the documentation but otherwise this is your guy's work.

The plugin issue that Girish raised in comment #9 has been split off into its own bug report: #1348518: Presets can reference plugins that are no longer available. I agree with the solution but I don't think it is appropriate to send along all variables.

It appears this issue has resurfaced in the 7.x-2.x branch of the module.
I it better to open a new issue or revive this ticket?

When a player is inserted through a wysiwyg player, like with the media module, the page is cached and subsequent page loads are missing
drupal_add_js(libraries_get_path('jwplayer') . '/jwplayer.js');
drupal_add_js(drupal_get_path('module', 'jw_player') . '/jw_player_seek.js');

The player is unable to load.

I don't see a better way than to add these in hook_init. Would it be preferable if this was a setting as not all sites may encounter this issue?

Which cache is actually causing the issue?

Instead of using drupal_add_js(), could #attached be used somewhere in a cached renderable array?

Page cache does include the JS added with drupal_add_js(). So the page being cached is not the issue. Could there be some other cache involved? How is the embed code inserted in the WYSIWYG created? Is the embedding done through a filter?

Marking this as duplicate since the refactor theming patch removes all inline JavaScript and renders players using #attached and Drupal.behaviors.

Please review: https://www.drupal.org/node/2713725

Sorry, forgot to change the status.