Hi
Thanks for the great theme
I use it myself in my site (http://dev-art.net , it's hebrew so i guess you wont understand ...)
I have RTL-ed it i have added http://drupal.org/project/internet_services_rtl

what i did was to duplicate the sytle.css to style-rtl.css and did the RTL changed there
duplicate & flip corder.gif to corner-rtl.gif

I wondered if you would care to merge this to your project this way there would be only one Bi-directional theme
I would do all the RTL work this time
But the new features would need to be RTL-ed too

Avior

Comments

hswong3i’s picture

hswong3i commented

feature add is always welcome ;-)
please attach the code that you change here. i will try to merge them into the theme. may be depend on different language, and include extra .css file if needed (for override css).
BTW, i will only take care about the first stage: merge RTL supporting into the theme. i am not suitable for coming on maintenance of this add-on feature, as i am using LTL.
therefore for any upgrade of this theme, i will first implement the LTL version, and need the patch submitted by you, or someone else ;-)

avior’s picture

avior commented

Hi
I am working on 5 RTL version , and i have a lot of problems, it seems that you have done a lot of changes
(I remember that RTLing 4.7 version was much easier...)
when i am done i will let you know , so you see the changes, and decide where to go from here

of course i (and others ) will be responsible about sytle-rtl.css new fetures

thanks
Avior

hswong3i’s picture

hswong3i commented

i start the drupal-5.x from drupal-4.7.x (stable release). the update of themes are almost parallel: which means they should only contain version dependent differences.

please refer to project release page (http://drupal.org/node/70320/release), and check the version that you are basing from. i will suggest to start your development under latest stable release, but not version before Feb 2007. internet_services is completely rewrite for stable release, and almost totally different from that before, for both 4.7.x and 5.x version.

hope this can decrease the time for your development ;-)

Regards,
Edison

avior’s picture

avior commented

Hi Adison

I think i have finished the work and ready to upload the work
I have 2 questions for you hope you can help

1. is it possible to have settings for the theme ?, I am asking because you use 768px as width and i prefer 98%, is it possible to have this as settings ?
2. how can i add 5.x version of the theme ?, I am using tortoiseCVS, I am using two separate directories and the files are different , i have asked a question

Thanks Avior

hswong3i’s picture

hswong3i commented
  1. this seems not the target of internet_services (http://drupal.org/project/internet_services):we are a fixed width, 2 column layout. change fixed pixel into percentage will break the layout, and also not the original design target.
  2. the reply (http://drupal.org/node/134577#comment-220355) already show out the correct direction for you.

BTW, please submit patch here. i will follow up about that.

hswong3i’s picture

hswong3i commented
Version: 5.x-1.1 » master
Assigned: Unassigned » hswong3i
Category: feature » task

RTL support will soon add to 6.x version. After most development for contented7 become stable, I will port the implementation to here. BTW, RTL support will not be implemented for 5.x version.

avior’s picture

avior commented

Thank you very much for your effort !

I have seen the cross post about this in the drupal.org.il site

I promise you to check the theme (when it will be ready.. )
when i will upgrade my site to 6.x

hswong3i’s picture

hswong3i commented
Title: RTL support » RTL support for 2.x
Version: master » 6.x-2.x-dev

@avior: Thanks for your support :)

Some summarize for RTL development:

  1. RTL should be functioning, if browser is Acid2 compatible. E.g. FF3, Opera9 (IE7 is an unexpected exceptional case...). Other browser may have mis-positioning (e.g. FF2 and IE6), but I am not going to fix it.
  2. Primary menu for RTL is now in wrong position.
  3. Theme search box should be revamp for i18n support. It is now a fixed width en-US implementation and so position will gone mess for other language, not only for RTL.
hswong3i’s picture

hswong3i commented
Status: Active » Fixed

The UI seems to be fine for RTL right now, even though a bit buggy for IE7.

avior’s picture

avior commented

Thank you *very* much for your effort RTLing the theme

I did have the time yet but i will let you know as soon as i check the theme
I just want to let you know that there are a few RTL sites that use this great theme

Thanks Avior

hswong3i’s picture

hswong3i commented

@avior: I have a look in drupal.org.il and found that there is a RTL theme section. I hope to post my themes to there so contribute for more people; BTW, I can't read and type RTL... Would you mind to give me a hand?

On the other hand, I would also like to list the sites using this theme to its project home page (it is not existing right now, but I will soon create it). I am really interesting about the user and how they use it. May you provide those URLs?

avior’s picture

avior commented

Hi Edison
sorry for the delay the theme is in drupal.org.il (it's here http://drupal.org.il/%D7%A2%D7%99%D7%A6%D7%95%D7%91/internet-services)

and here is a link to Contented7- http://drupal.org.il/node/1824 (it's pointing to drupal.org)

currently it's mixed 5.x and 6.x

i can link to 3 internet_services rtl sites
http://dev-art.net (my site)
http://yadharifartscenter.co.il/
http://www.visualist.co.il/

Thank you again for you great themes and effort RTLing !

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.