Thanks for this module, solved a definite problem for a client.

There are two instances of the deprecated call time pass-by-reference use in search_autocomplete.module, as noted in the following warnings that appear when the module is enabled via drush:

PHP Warning: Call-time pass-by-reference has been deprecated in /home/clients/websites/w_vfs/public_html/vfs/sites/all/modules/contrib/search_autocomplete/search_autocomplete.module on line 106

PHP Warning: Call-time pass-by-reference has been deprecated in /home/clients/websites/w_vfs/public_html/vfs/sites/all/modules/contrib/search_autocomplete/search_autocomplete.module on line 109

I confirmed that moving the pass-by-reference &'s from the calls to the functions resolves this issue. There are no other calls to these functions anywhere else in the search_complete module. Still avoiding git at this point so no patch for you :-)

Comments

dom.’s picture

dom. commented

Hi!

Thanks a lot for reporting!
This is still an alpha "on the way" to 2.0 In 2.0, those two functions do not exist anymore. Indeed I don't see the point in having the choice between core or embedded autocompletion knowing that embedded solution offers more options. So I will remove this choice.
I'm waiting for the answer to a dev issue (mabe you know and can help!) :
http://drupal.org/node/1311352
then I will release the 2.0-beta1 which should have all the functions I wish for 2.0 It will fixe the bug you just reported.

I'm happy this module helps.

Miro

dom.’s picture

dom. commented
Status: Active » Closed (fixed)