The current api doc for hook_schema() does not mention at all that the database tables returned by implementations will be automatically created. Yes, everyone KNOWS that. Except those who don't. Strangely, the doc for hook_install() actually provides this information, but it really should be in the hook_schema doc as well.
(Will roll a patch.)
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | doc-hook_schema-autoloaded-1312844-22.patch | 732 bytes | kathyh |
| #13 | doc-hook_schema-autoloaded-1312844-13.patch | 712 bytes | kathyh |
| #5 | doc-hook_schema-autoloaded-1312844-5.patch | 1.34 KB | sven.lauer |
| #1 | doc-hook_schema-autoloaded-1312844-1.patch | 1.32 KB | sven.lauer |
Comments
Comment #1
sven.lauer commentedAnd a patch.
Comment #2
jhodgdonThanks, this looks like a good addition to the docs! I also verified by looking at module_enable() and drupal_uninstall_modules() that the doc is correct about when things happen.
Comment #3
webchick#1: doc-hook_schema-autoloaded-1312844-1.patch queued for re-testing.
Comment #5
sven.lauer commentedAh, I guess this patch conflicted with the one in #1307062: install file hooks should state whether module code is available. Re-rolling.
(If the testbot is happy, I'll set this back to RTBC, as nothing has changed.)
Comment #6
jhodgdonComment #7
catchThanks! Committed to 8.x. Leaving RTBC for 7.
Comment #8
catch#5: doc-hook_schema-autoloaded-1312844-5.patch queued for re-testing.
Comment #9
webchickCommitted and pushed to 7.x. Thanks!
Comment #10
David_Rothstein commentedDid someone type backspace when they meant to type a period?... Strange, they aren't even close to each other on the keyboard :)
Comment #11
catchWhoops.
Comment #12
jhodgdonWhoops indeed. At least three of us missed that. Thanks David!
Good novice issue to fix that problem...
Comment #13
kathyh commentedSince patch from comment#5 was already committed, this patch corrects only comment #10.
Comment #14
David_Rothstein commentedLooks good, thanks :)
Comment #15
jhodgdonAfter committing, this needs to be D7 / to be ported, and a patch made combining #13 and #5. Thanks!
Comment #16
David_Rothstein commentedI think #5 was already committed to D7, actually? (In which case this followup can just go into both D7 and D8 at the same time.)
Comment #17
jhodgdonTrue. :)
Comment #18
catch#13: doc-hook_schema-autoloaded-1312844-13.patch queued for re-testing.
Comment #20
kathyh commented#13: doc-hook_schema-autoloaded-1312844-13.patch queued for re-testing.
Comment #22
kathyh commentedRe-rolled for D8 core dir change - 11/1/11
Comment #23
sven.lauer commentedLooks good, thanks for fixing (and re-rolling the fix for) my oversight!
This will need a re-re-roll for D7 once committed.
Comment #24
catchCommitted/pushed to 8.x, thanks! Moving to 7.x.
Comment #25
sven.lauer commented#13: doc-hook_schema-autoloaded-1312844-13.patch queued for re-testing.
Comment #26
jhodgdonThanks, looks like #13 is good for D7. Not very controversial to apply it. :)
Comment #27
webchickCommitted and pushed to 7.x. Thanks!