Additional fields

yeah, that would be really useful. Doesn't have to be displayed by default. As long as the information was in the field items array you could then easily display what you want with a simple field template override.

Thanks,
Rene

jec006 any ideas how we would tackle this? Add another serialised column in the database to hold a data array, then add a callback hook which fetches additional video data for that specific type and stores it in the database?

We would only be able expose this additional data in theme functions though. What do you think, have any better ideas for implementing this?

I'm happy to do the dirty work just wanted to see if you had any bright ideas.

Cheers

Nearly there I think.

- Adds a data database column.
- Provides a template file that can be overridden in your theme so you can use the data to display what you want.
- Other bits cleaned up here and there.

Example overridden template file:

<?php
/**
 * @file
 * Default theme implementation to display a video embed field.
 *
 * Variables available:
 * - $url: The URL of the video to display embed code for
 * - $style: The style name of the embed code to use
 * - $style_settings: The style settings for the embed code
 * - $handler: The name of the video handler
 * - $embed_code: The embed code
 * - $data: Additional video data
 *
 * @see template_preprocess_video_embed()
 */
?>

<div class="embedded-video">
  <div class="player">
    <?php print $embed_code; ?>
  </div>
  <?php if ($handler == 'vimeo') print t('Video uploaded by !user', array('!user' => l($data['user_name'], $data['user_url']))); ?>
</div>

Might need to re-work things for the colorbox side of things as well?

Hey, I'm sorry for the delay

Was thinking about it, but will review your patch and let you know if I have something better.

thanks again :)

This is awesome - any chance this data could be exposed to views as well?

Thanks as always jdelaune

Committed here: http://drupal.org/commitlog/commit/25834/3c2fbc23b0922b3c37eda8452831c6d...
and added a bit of stuff here: http://drupal.org/commitlog/commit/25834/080a6062a8dac586e2664839e3cc3af...

if you wouldn't mind checking that first commit, I had to do some hand merging because I updated a few things before reading your patch. I tested things and it all seems good, but let me know if I missed something.

As far as views integration: that would be sweet, however, right now the data is serialized and we don't really know what will be in it (as the providers can have different data) so I'm not sure how we'd go about showing views that data in a useful way.

It might be nice (though this is really ambitious) to add stuff to the settings to let you expose some of it. We'll have to see. Would you mind moving that to a new issue deckfifty?

Thanks everyone

Doing that to display duration? Did anyone looked what data array contain?

$data['media$group']['media$content'][0]['duration']

+ An idea to put description value out of $embed_code. Now if I want to print description value before video, I have to modify field.tpl.php (or node template) and from there I can get the youtube values, so what is the point of this template file? Or am I doing smt wrong?

The description field is different because it's user modifiable. The description you get from YouTube or Vimeo etc isn't.

link added.