Currently, if the payment method is in TEST mode, the module discards its payment data in favour of test data provided by SagePay (http://www.sagepay.com/help/faq/how_can_i_test_the_different_card_types).

This means it is impossible to test the how the module fails, as any bad data will be replaced by this approved test data.

My feeling is that it should be the responsibility of the tester to supply good/bad test data. The module should respect the data entered.

Comments

ikos’s picture

ikos commented
Status: Active » Needs review

This was in place for speed of testing.

I have left it in place, but added a setting in the module to allow you to turn this off.

kingandy’s picture

kingandy
he/him
commented

Cool. Any idea when a new -dev release will be rolled? I was under the impression it happened automatically once a day.

kingandy’s picture

kingandy
he/him
commented

Still waiting for a new dev release to be rolled. Can't review the change until this is done or a patch is posted.

ikos’s picture

ikos commented

Hi,

Sure sorry about that.. Seem to have got my git clone messed up as I thought I'd done it.

When I'm home later I'll check it out again and see if I can commit a few of these patches.

Rich

ikos’s picture

ikos commented

Hi,

Made some changes tonight to hopefully fix the git repo. Will find out when the next dev release is rolled.

R

ikos’s picture

ikos commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.