Hi!

I find the textfield-only #field_suffix and #field_prefix very helpful and I've already overridden theme_form_element() theme-level to make them available for all fields, and it's working out great.

Attached a patch that removes them from theme_textfield() and add them to the more generic theme_form_element() for core.

CommentFileSizeAuthor
#15 drupal.field-prefix-suffix.15.patch1.66 KBsun
#13 field_prefix_suffix_for_all4.patch1.8 KBdawehner
#7 field_prefix_suffix_for_all4.patch2.05 KBdawehner
#5 field_prefix_suffix_for_all3.patch1.75 KBdawehner
#3 field_prefix_suffix_for_all2.patch1.46 KBAmrMostafa
field_suffix_prefix_for_all.patch1.5 KBAmrMostafa

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

No longer applies.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Version: 6.x-dev » 7.x-dev

Moving feature requests to the D7 queue.

AmrMostafa’s picture

AmrMostafa commented
Component: theme system » forms system
Status: Needs work » Needs review
StatusFileSize
new field_prefix_suffix_for_all2.patch1.46 KB

Patch updated to HEAD.

Status: Needs review » Needs work

The last submitted patch failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new field_prefix_suffix_for_all3.patch1.75 KB

just a rerole

Status: Needs review » Needs work

The last submitted patch failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new field_prefix_suffix_for_all4.patch2.05 KB

reroll

cburschka’s picture

cburschka
they
commented

Which non-textfield elements do we need this for? Select? Seeing as checkbox and radio labels are already printed like a #field_suffix, and it's difficult to imagine a situation where you want something to the left of them...

I suppose it can't hurt to add support for it, though.

I can see no code-style problems with this patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Makes sense to centralise this in theme_element(), and theme_textfield() is a bit of a mess as well (really shouldn't have the autocomplete stuf in there either).

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new field_prefix_suffix_for_all4.patch1.8 KB

here is the rerole

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: field_suffix & field_prefix for all » #field_prefix and #field_suffix work on textfields only
Assigned: AmrMostafa » Unassigned
Category: feature » bug
Status: Needs work » Needs review
StatusFileSize
new drupal.field-prefix-suffix.15.patch1.66 KB

Oh my. I thought we would have fixed this totally annoying bug long ago?! Just ran into the same issue in contrib. Again.

Re-rolled from scratch against HEAD.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

RTBC again.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

#15: drupal.field-prefix-suffix.15.patch queued for re-testing.

This is a good idea, let's get it in.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kkaefer’s picture

kkaefer commented

Fix for this patch in #755030: Regression: #field_prefix/suffix is displayed before the label