Currently, there are properties for the identifiers pointing to an entity. There should be properties pointing to the entities instead though.
Also see "handling entity references" at http://drupal.org/node/1021466.
Attached patch starts to convert the properties. As a result the generated views fields are renamed though + the relationships are auto-generated, so one would have to remove the existing relationships and go through the default views to search/replace "order_id" references with "order" + the same for coupon_id/coupon...
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | entity.1314364.join-with-bundle-types.patch | 742 bytes | thehong |
| commerce_coupon_properties.patch | 3.01 KB | fago |
Comments
Comment #1
thehong commentedApplied: 3ea336c. Thank you.
Comment #2
thehong commentedComment #3
webmasterkai commentedComment #4
thehong commentedFixed, but we need this simple patch for entity module, without this patch, it will add join condition like this if we do not select any bundle:
INNER JOIN commerce_coupon ... WHERE commerce_coupon.type IN ('0', '0').Comment #5
thehong commented(try attach patch again)
Comment #6
webmasterkai commentedPerhaps an issue should be created on the Entity API project to apply the patch?
Comment #7
geek-merlinupsi, these patches seemdd to cause a regression at #1315022: Emptying cart with coupon applied throws error
maybe linked a flaw here
@fago, would be nice to do a review there
Comment #8
thehong commentedComment #9
pcambraCoupon->order relationships are now managed by EntityReference.
Marking this as fixed again, thanks!