In this version of the function signup_cancel_signup() I have add:

- WatchDog log for Un-signup(un-subscribe)
- Mail to Admin of who join out.

In my opinion Admin must know who join out!!
This function work perfectly on signup.module,v 1.45.2.41 , this version work fine!!!

Thanks, Uccio

Ps: Sorry but mi Diff tool work bad!!
Ps: I can't test the anonimus version of this script!

CommentFileSizeAuthor
signup-cancel.txt1.93 KBuccio

Comments

dww’s picture

Status: Reviewed & tested by the community » Needs review

thanks for the patch. however,

- this needs review before i'd commit it.

- i'm not adding new features to the 4.7.x-1.* series. new features will only happen in 5.x-2.* (and maybe 4.7.x-2.*, if there's enough interest in new features compatible with 4.7.x core).

JohnG-1’s picture

+1 Uccio's suggestion makes a lot of sense - notifying the organiser when a sign-up drops out is a good idea, perhaps even leaving them greyed-out and marked 'drop-out' on the signup list ... ;)

I guess the watchdog thing is just about logging the cancellation action in the way all drupal events should be logged ?

I was tempted to change
the title to Reinstate cancellation notifications,
the version to HEAD,
the status to patch - code needs work,
so that this feature request will be including when new features are being considered ... but I don't want to mess up dww's rigorous maintenance system ... ;)

dww’s picture

Version: 4.7.x-1.x-dev » 5.x-2.x-dev
Status: Needs review » Needs work

a) yeah, the watchdog() call is basically fine (though it needs to be ported to 5.x's use of t() placeholders).

b) the email notification on the cancelation needs to be more flexible. there should be a way to control if this email gets sent, who it's sent to, etc. probably we could reuse the same "forwarding_email" field in the db (which should be renamed, in fact) in terms of who to send it to. in fact, perhaps we should just say that if you define that notification email, that you automatically get emails on both signups and cancelations -- that's probably good enough. so, instead of hard-coding to always send it to site_mail, we need to see if forwarding_email is defined for this node, and if so, use that.

p.s. it's better to post real patches, not whole copies of functions. see http://drupal.org/patch for more.

JohnG-1’s picture

@ #3b (dww) +1 : use Notification Email function for both sign-ups and cancellations ... sounds like a good approach :)

bchoc’s picture

A step further than using the same notification function, both cancellation and sign-ups could be subject to the cut-off time.

In a sense, a cancellation becomes just a "negative sign-up" from a workflow point of view.

JohnG-1’s picture

You mean apply close sign-ups x hours before event to both sign-ups and cancellations ? that makes sense.

dww’s picture

Title: Added 2 useful features [in my opinion] » Signup cancelation notification

Better title so people can find this. #190142: Cancel notification marked duplicate.

dww’s picture

Note to people who care about this: hook_signup_cancel() is invoked whenever someone cancels a signup, so it's easy to do stuff like this in your own modules if you need to.

dww’s picture

I think the basic concept articulated in this feature request is a good one.
However, I believe the whole email functionality of this module is weird and needs rethinking.
Therefore, this is hereby postponed in favor of #290305: Split out email functionality into separate submodule(s).

dww’s picture

Status: Needs work » Postponed
duaelfr’s picture

Status: Postponed » Closed (won't fix)

This version of Signup is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.

simon georges’s picture

Status: Closed (won't fix) » Postponed

Reverting recent closing.