Don't USE absolute link in image urls

Upping this to major since this can cause broken images when one of the CSS files created by this module is shared between multiple domains and one of those domains is private (say for example when you route content editors through a private domain that is restricted via HTTP authentication, VPN, private DNS or whatever).

This will also make it more difficult to make the module compatible with all of the various CDN technologies out there.

Agreed - fixed in http://drupalcode.org/project/menu_icons.git/commit/3825076

There's a problem with the solution that got committed. It doesn't resolve internal file URIs, like file_create_url() did. For example, now I'm seeing this in my CSS if I choose an image style:

background-image: url(/public://styles/none/public/menu_icons/menu_icon_821.png)

We should use file_create_url() to resolve the internal URI, and then strip out the base url. See the attached patch, which works for me.

This is fixed in dev, and is also a duplicate of #1399516: Icons disappear after update.