Ability to save exposed filters state only for registered users?

There's a module that will save exposed filters. I forget its name, though, but if you look around for...hmm. saved searched? saved filters? I forget exactly.

OH. Hm.

Indeed those probably should not remember the values for anonymous users in any case. That might actually be considered a bug.

I just ran into this too when setting up Varnish. I like your solution and I don't see anything obviously wrong with it.

Did you have more that you wanted to do, or should it be set 'needs review' ?

+++ b/handlers/views_handler_filter.incundefined
@@ -71,6 +71,7 @@ class views_handler_filter extends views_handler {
+        'remember_roles' => array('default' => array(DRUPAL_AUTHENTICATED_RID => (string)DRUPAL_AUTHENTICATED_RID)),

Why cast to a string? And if it is necessary, put a space after the (string) cast.

+++ b/handlers/views_handler_filter.incundefined
@@ -336,6 +337,17 @@ class views_handler_filter extends views_handler {
+      '#title' => t('Roles to remember section for'),

selection, not section, and if this can be reworded to not end in a preposition, that'd be great

+++ b/handlers/views_handler_filter.incundefined
@@ -336,6 +337,17 @@ class views_handler_filter extends views_handler {
+        'edit-options-expose-remember' => array(1)

missing trailing comma

+++ b/handlers/views_handler_filter.incundefined
@@ -546,6 +558,15 @@ class views_handler_filter extends views_handler {
+    $allowed_rids = array_values($this->options['expose']['remember_roles']);

This doesn't check if the array is empty first, which will throw notices. In addition, there doesn't seem to be a way to know if this value was never set, or if it's purposefully emptied out.

+++ b/handlers/views_handler_filter.incundefined
@@ -546,6 +558,15 @@ class views_handler_filter extends views_handler {
+    $intersect_rids = array_intersect($allowed_rids, $user_rids);

Wouldn't there be no need for the array_values/array_keys functions if array_intersect_key was used instead?

It would be cool if some validation would filter out empty values, so unchecked roles isn't stored. There is options_validate which you can use. Just did that.

The patch from #10 does not allow to save the role selection when all values are emptied out. The patch from #9 is OK. I have only rephrased the description and sent user_roles() through check_plain() (as done in core - block.admin.inc).

I think this is RBTC, but someone else should take another look.

Looks OK to me.

Rerolled.

The code looks good now. Thanks for all your work, committed to 7.x-3.x

As things got changed it has to be ported.

+++ b/handlers/views_handler_filter.incundefined
@@ -387,6 +390,18 @@ class views_handler_filter extends views_handler {
+      '#dependency' =>  array(
+        'edit-options-expose-remember' => array(1),

D8 uses #states now so this part has to be changed.

Thanks for the port! Committed to 8.x-3.x