sympa_subscribe

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

coder on minor

I noticed some very small code style issues. Please run the Coder module on "minor" setting to help catch these. The coding standards have even more information in this area. I noticed things like ...

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

Severity minor, Drupal Coding Standards
sites/all/modules/sympa_subscribe/sympa_subscribe.module:
 +4: [minor] There should be no trailing spaces
 +73: [minor] There should be no trailing spaces
 +74: [minor] There should be no trailing spaces
 +181: [minor] There should be no trailing spaces
 +183: [minor] There should be no trailing spaces
Status Messages:
 Coder found 1 projects, 1 files, 5 minor warnings, 0 warnings were flagged to be ignored

Severity minor, Drupal Security Checks
sites/all/modules/sympa_subscribe/sympa_subscribe.module:
 +64: [critical] Use the Form API to build forms to help prevent against CSRF attacks.
 +86: [critical] Use the Form API to build forms to help prevent against CSRF attacks.
 +105: [critical] Use the Form API to build forms to help prevent against CSRF attacks.
Status Messages:
 Coder found 1 projects, 1 files, 3 critical warnings, 0 warnings were flagged to be ignored

Severity minor, Drupal Commenting Standards
sites/all/modules/sympa_subscribe/sympa_subscribe.module:
 +4: [minor] @file description should be on the following line
 +11: [minor] put a space between the asterisk and the comment text
 +152: [minor] put a space between the asterisk and the comment text
Status Messages:
 Coder found 1 projects, 1 files, 3 minor warnings, 0 warnings were flagged to be ignored

Automated test results:

coder on minor

I noticed some very small code style issues. Please run the Coder module on "minor" setting to help catch these. The coding standards have even more information in this area. I noticed things like ...

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

/sympa_subscribe.module:
 +207: [critical] Use the Form API to build forms to help prevent against CSRF attacks.
 +229: [critical] Use the Form API to build forms to help prevent against CSRF attacks.
 +248: [critical] Use the Form API to build forms to help prevent against CSRF attacks.

Status Messages:
 Coder found 1 projects, 1 files, 3 critical warnings, 0 warnings were flagged to be ignored

coder review of info file

I noticed some very small code style issues. Please run the Coder module on "minor" setting to help catch these. The coding standards have even more information in this area. I noticed things like ...

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

Severity minor, Project application tests - Info

/sympa_subscribe.info:
 +5: [normal] Remove 'version' from the info file, it will be added by drupal.org packaging automatically.

Status Messages:
 Coder found 1 projects, 1 files, 1 normal warnings, 0 warnings were flagged to be ignored

coder_tough_love and comments on minor

This is optional.

Severity minor, Project application tests - Comments, Coder Tough Love

/sympa_subscribe.module:
 +4: [minor] All comments should end with a ".".
 +9: [minor] All comments should end with a ".".
 +16: [minor] All comments should end with a ".".
 +18: [minor] All comments should end with a ".".
 +34: [minor] All comments should start capitalized.
 +34: [minor] All comments should end with a ".".
 +35: [minor] All comments should start capitalized.
 +35: [minor] All comments should end with a ".".
 +54: [normal] Function summaries should be one line only.
 +72: [minor] All comments should end with a ".".
 +80: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia)
 +89: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia)
 +98: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia)
 +132: [minor] All comments should end with a ".".
 +134: [minor] All comments should end with a ".".
 +135: [minor] All comments should end with a ".".
 +189: [minor] All comments should end with a ".".
 +204: [minor] All comments should end with a ".".
 +204: [normal] Doxygen uses @todo and @bug to markup things to be done.
 +274: [minor] All comments should start capitalized.
 +274: [minor] All comments should end with a ".".

Status Messages:
 Coder found 1 projects, 1 files, 5 normal warnings, 16 minor warnings, 0 warnings were flagged to be ignored

You need to set the status to "needs review" if you want to get a review.

The response time for a review is now approaching 4 weeks. Get a review bonus and we will come back to your application sooner.

please visit http://ventral.org/pareview/httpgitdrupalorgsandboxblairchristensen13145... for the list of errors being generated.

don't block deeper reviews because of minor coding standart issues found by automated reviews

Hello,

Manual Review :

sympa_subscribe.module :
1. You have to provide file comment which should start with @file.
2.drupal_set_message( $result->error, 'error' );=> you have to use t() in set message.Also here , $result->error is a dynamic value, so use placeholders.
3. watchdog( SYMPA_SUBSCRIBE, 'subscription request: code=' . $result->code . ' error=' . $result->error ) => use place holders for dynamic value and add t() for messages.
4. Please check all the watchdog functionality, whether it contains t() and pplaceholders for dynamic value.
5. Use valid_email_address() functionality instead of "function sympa_subscribe_form_validate($form, &$form_state) " for validating mail address.
6.It seems there are so many indent errors.Please fix it all.
7. Please Check http://ventral.org/pareview/httpgitdrupalorgsandboxblairchristensen13145...

Thanks

note that you should not use t() within a watchdog() call.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

added clone URL + drupal versions