Download & Extend
Twitter » Issues

Implement Actions and Rules integration for Drupal 7

Posted by juampy on October 21, 2011 at 6:07pm
Project:Twitter
Version:7.x-3.x-dev
Component:Code
Category:task
Priority:major
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

After reading the code of twitter_actions, I see that it has not being ported to Drupal 7.

A full code review needs to be done so it integrates correctly with Actions, Trigger and Rules modules.

I have closed the issues related to twitter_actions as they only report specific bugs created by the unstable status of the submodule, which are:

I will post here progress over the following days. Patches are very welcome.

Login or register to post comments

Comments

#1

Posted by juampy on November 13, 2011 at 5:22pm
Category:feature request» task

Changed category to "task".

#2

Posted by aguskii on November 19, 2011 at 2:26pm

Just exposing twitter actions to triggers.
PATCH attached.
Please review.

AttachmentSize
twitter_actions_available_for_triggers_1317196.patch 1.02 KB

#3

Posted by aguskii on November 19, 2011 at 4:03pm
Status:active» needs review

Changing status, needs review

#4

Posted by e0ipso on November 19, 2011 at 5:45pm

Adds support for rules and fixes error when enabling rules and twitter at the same time.

#5

Posted by e0ipso on November 19, 2011 at 5:47pm

The actual patch :-P

AttachmentSize
twitter_actions_rules_integration-1317196-5267134.patch 2.29 KB

#6

Posted by e0ipso on November 20, 2011 at 9:47am

I updated the previous patch adding some useful conditions (at least for my own use case).

AttachmentSize
adds_conditions_and_actions_to_rules-1317196.patch 4.43 KB

#7

Posted by juampy on November 20, 2011 at 10:03pm
Title:Port twitter_actions submodule» Implement Rules integration for Drupal 7
Status:needs review» fixed

Applied patch by e0ipso.

aguskii, e0ipso, many thanks for the effort!

http://drupalcode.org/project/twitter.git/commitdiff/c392ea24b1d59faa5d9...

#8

Posted by aguskii on November 21, 2011 at 9:38am

Hi,
I can´t see the patch #2 applied.
Notice that it is different from the patch #6. (The patch #6 has been applied, but the other one has not).

Without this patch, twitter action won´t be exposed to admin/structure/trigger/node.

I attached the patch again (I renamed with #comment info).
Please review and applied

AttachmentSize
twitter_actions_available_for_triggers-1317196-8.patch 1.02 KB

#9

Posted by aguskii on November 21, 2011 at 9:39am
Status:fixed» needs review

Changing the status

#10

Posted by juampy on November 21, 2011 at 10:34am
Title:Implement Rules integration for Drupal 7» Implement Actions and Rules integration for Drupal 7

aguskii, doh!, you are right. I will check this in the afternoon.

#11

Posted by juampy on November 21, 2011 at 5:36pm
Assigned to:juampy» Anonymous
Status:needs review» needs work

aguskii, this patch needs further work. I tested it with a node create trigger and it did not work because $context['hook'] had "node_insert" instead of "node".

Please test it yourself and add the relevant hooks.

#12

Posted by aguskii on November 22, 2011 at 9:33am

Ok juampy thanks for the fast response.

#13

Posted by aguskii on November 29, 2011 at 7:11pm

Hi,
I have not much experience with actions and I think it needs more work, but I have added a new patch with some comments and it is working for me.
I have some questions:
1 - Why we use case: workflow? It was implemented for something that it is not present on D7 version?
2 - I've removed case: taxonomy, since there is not trigger implemented for taxonomy in the twitter_actions_action_info. Should we implement taxonomy triggers too?

Please test the patch and juanpy point me in the right direction... since I am not sure if the implementation that I've made is Ok.

AttachmentSize
twitter_actions_available_for_triggers-1317196-13.patch 6.37 KB

#14

Posted by aguskii on November 29, 2011 at 7:48pm

Uuuupsss,
I mixed the body with the teaser (summary), here is the right patch.
And I've notice that messages up to 140 chars will not be posted to twitter and there is no feedback to the user telling him that the message couldn´t be sent.

AttachmentSize
twitter_actions_available_for_triggers-1317196-14.patch 6.37 KB

#15

Posted by aguskii on November 29, 2011 at 8:40pm
Status:needs work» needs review

Now the %username for comments have been changed, from the node author to the comment "name" (anonymous or the name that the user has typed in).

AttachmentSize
twitter_actions_available_for_triggers-1317196-15.patch 6.38 KB

#16

Posted by aguskii on December 1, 2011 at 8:37pm

Hi,
I added some doc and clean some code.
It is working fine so far, comments and reviews will be very welcome!

AttachmentSize
twitter_actions_available_for_triggers-1317196-16.patch 8.66 KB

#17

Posted by rodrigoaguilera on December 2, 2011 at 5:49pm
Status:needs review» reviewed & tested by the community

Works fine for me.
Great work

#18

Posted by juampy on December 3, 2011 at 6:47pm
Status:reviewed & tested by the community» fixed

Applied. Aguskii, many thanks for the great job.

http://drupalcode.org/project/twitter.git/commitdiff/a9d451e60c92df35b67...

#19

Posted by GiorgosK on December 4, 2011 at 4:31pm

please update the module page to reflect rules support

#20

Posted by System Message on December 18, 2011 at 4:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here