After reading the code of twitter_actions, I see that it has not being ported to Drupal 7.

A full code review needs to be done so it integrates correctly with Actions, Trigger and Rules modules.

I have closed the issues related to twitter_actions as they only report specific bugs created by the unstable status of the submodule, which are:

I will post here progress over the following days. Patches are very welcome.

CommentFileSizeAuthor
#16 twitter_actions_available_for_triggers-1317196-16.patch8.66 KBtuwebo
#15 twitter_actions_available_for_triggers-1317196-15.patch6.38 KBtuwebo
#14 twitter_actions_available_for_triggers-1317196-14.patch6.37 KBtuwebo
#13 twitter_actions_available_for_triggers-1317196-13.patch6.37 KBtuwebo
#8 twitter_actions_available_for_triggers-1317196-8.patch1.02 KBtuwebo
#6 adds_conditions_and_actions_to_rules-1317196.patch4.43 KBe0ipso
#5 twitter_actions_rules_integration-1317196-5267134.patch2.29 KBe0ipso
#2 twitter_actions_available_for_triggers_1317196.patch1.02 KBtuwebo

Comments

juampynr’s picture

juampynr commented
Category: feature » task

Changed category to "task".

tuwebo’s picture

tuwebo commented
StatusFileSize
new twitter_actions_available_for_triggers_1317196.patch1.02 KB

Just exposing twitter actions to triggers.
PATCH attached.
Please review.

tuwebo’s picture

tuwebo commented
Status: Active » Needs review

Changing status, needs review

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Adds support for rules and fixes error when enabling rules and twitter at the same time.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new twitter_actions_rules_integration-1317196-5267134.patch2.29 KB

The actual patch :-P

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new adds_conditions_and_actions_to_rules-1317196.patch4.43 KB

I updated the previous patch adding some useful conditions (at least for my own use case).

juampynr’s picture

juampynr commented
Title: Port twitter_actions submodule » Implement Rules integration for Drupal 7
Status: Needs review » Fixed

Applied patch by e0ipso.

aguskii, e0ipso, many thanks for the effort!

http://drupalcode.org/project/twitter.git/commitdiff/c392ea24b1d59faa5d9...

tuwebo’s picture

tuwebo commented
StatusFileSize
new twitter_actions_available_for_triggers-1317196-8.patch1.02 KB

Hi,
I can´t see the patch #2 applied.
Notice that it is different from the patch #6. (The patch #6 has been applied, but the other one has not).

Without this patch, twitter action won´t be exposed to admin/structure/trigger/node.

I attached the patch again (I renamed with #comment info).
Please review and applied

tuwebo’s picture

tuwebo commented
Status: Fixed » Needs review

Changing the status

juampynr’s picture

juampynr commented
Title: Implement Rules integration for Drupal 7 » Implement Actions and Rules integration for Drupal 7

aguskii, doh!, you are right. I will check this in the afternoon.

juampynr’s picture

juampynr commented
Assigned: juampynr » Unassigned
Status: Needs review » Needs work

aguskii, this patch needs further work. I tested it with a node create trigger and it did not work because $context['hook'] had "node_insert" instead of "node".

Please test it yourself and add the relevant hooks.

tuwebo’s picture

tuwebo commented

Ok juampy thanks for the fast response.

tuwebo’s picture

tuwebo commented
StatusFileSize
new twitter_actions_available_for_triggers-1317196-13.patch6.37 KB

Hi,
I have not much experience with actions and I think it needs more work, but I have added a new patch with some comments and it is working for me.
I have some questions:
1 - Why we use case: workflow? It was implemented for something that it is not present on D7 version?
2 - I've removed case: taxonomy, since there is not trigger implemented for taxonomy in the twitter_actions_action_info. Should we implement taxonomy triggers too?

Please test the patch and juanpy point me in the right direction... since I am not sure if the implementation that I've made is Ok.

tuwebo’s picture

tuwebo commented
StatusFileSize
new twitter_actions_available_for_triggers-1317196-14.patch6.37 KB

Uuuupsss,
I mixed the body with the teaser (summary), here is the right patch.
And I've notice that messages up to 140 chars will not be posted to twitter and there is no feedback to the user telling him that the message couldn´t be sent.

tuwebo’s picture

tuwebo commented
Status: Needs work » Needs review
StatusFileSize
new twitter_actions_available_for_triggers-1317196-15.patch6.38 KB

Now the %username for comments have been changed, from the node author to the comment "name" (anonymous or the name that the user has typed in).

tuwebo’s picture

tuwebo commented
StatusFileSize
new twitter_actions_available_for_triggers-1317196-16.patch8.66 KB

Hi,
I added some doc and clean some code.
It is working fine so far, comments and reviews will be very welcome!

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
Status: Needs review » Reviewed & tested by the community

Works fine for me.
Great work

juampynr’s picture

juampynr commented
Status: Reviewed & tested by the community » Fixed

Applied. Aguskii, many thanks for the great job.

http://drupalcode.org/project/twitter.git/commitdiff/a9d451e60c92df35b67...

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented

please update the module page to reflect rules support

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.