Remove assertion for final installation page

Postponing, pending consensus on #318975: Remove confirmation page after installation.

I may be mistaken, but I've the impression that we have consensus on #318975: Remove confirmation page after installation in the meantime.

Could we move forward here?

I've the impression that people do not want to RTBC the core patch, because it contains a temporary hack for PIFR :-/

Revisiting this, I would still like to assert *something*, as I've seen bots fail and return a white screen at this point in the past. That said, we should definitely put this on the Szeged agenda, and my Drupal vacation ends in the morning. ;)

Once #1808220: Remove run-tests.sh dependency on existing/installed parent site is fully deployed to PIFR/testbots, tests for D8 won't go through this manual installation code in PIFR in the first place.

For D8, we have proper tests for the interactive installer in Drupal core already — PIFR does not need to confirm anything manually beyond those tests.

For previous versions, this check could still be useful. → Instead of removing the line, let's wrap it in a version condition < 8.x?

Yup ... I can support that.

FYI, this "hidden" code shows up for all Drush installs so it would be nice to remove it.

Remove the code ... this assertion no longer exists, now that the bots are all using the 6.x-3.x branch. It was removed when the testbot was converted over to use drush si for installs.

Not marking as 'fixed' quite yet, because I don't want this to fall off the radar, given that there are also issues to remove the drush dependency on testbot.

Per #2274167-241: [ignore] Patch testing issue it seems the code in core is no longer needed. Is it safe now to remove it?

As per #9, it should now be safe to remove it ... a quick scan through the file referenced in the patch on this issue (which I haven't done recently) could be done to confirm I wasn't imagining things when I wrote that. :)

So I checked and 6.x-3.x no longer contains any such assertion (here's the relevant file: http://cgit.drupalcode.org/project_issue_file_review/tree/review/drupal/... ; I also did a full grep on the PIFR codebase and the corresponding string is nowhere to be found)

So I'm assuming that means this can be closed?!

The Drupal core issue got in (see related issues), so closing this now.