Port role_export to Drupal 6.x

Thank you for the port patch I will review it this weekend.

I've reviewed the port and I see some errors due to functions not existing in D6 and also form elements not existing in six. These should be easy to fix. I'll do my best to work on this for this weekend.

I will make a D6 branch so if you want to check out the files and make git patches to what you currently have you are more than welcome. In fact encouraged ;)

A 6.x-1.x branch has been made. I believe Drupal still does a midnight process. So it will be there tomorrow morning at the latest. Or you can check it out via git ;)

I've converted everything except the hook_user_role_insert() function from D7. This doesn't exist in D6. Also there's not a hook to insert a role into the system in D6. However, features is handling this and would like to at least support features. Any other module that is doing it a round about way will more than likely not be supported.

Also, the machine name field hasn't been javascripted yet. Which will need to be done.

Right currently working on a solution. We need a post processing hook for the D6 version of features. I'm going to try and team up with some maintainers of features to tackle this. At the very least learn features enough to create my own post processing hook and see if I can send it to features as a patch.

Looks like there has been a lot of talk looking for some type of post processing hook on the features queue. Look here http://drupal.org/node/981248

A possible way around this could be to cache the current roles. Then when a feature is installed I believe it clears all cache. Then if cache doesn't exist, go to the database modify any roles to have the current machine name and rid. Next create the new cached version of the roles. Only issue is what hook to use to fire this off after modules are installed.

Possibly hook_init(), this happens during each page load. I believe this would work just find but it seems like a serious work around.

Smokris, I have just committed to the 6.x branch (Will be Oct 25 dev version). So far from what I can tell this should be a solution. Please test this and let me know if it also works for you.

NOTE:: Make sure to fill in the Machine Name field on the roles page when creating a new role. The function for generating the Machine Name uses this fields input like the D7 version.

P.S. Let me know asap if you can. If all is well I will start on making the Machine Name field act like the features machine_name field.

Neither Klausi or I have interest in creating the D6 version. So until more help or volunteers are available I am postponing this port.

I tried the latest DEV release and from my testing it looks like Smokris #6 issue is resolved.

I'd be interested in helping or testing.

I know I've taken this a long way already. However, there are some downfalls in D6 that I don't have in D7. Mainly all the role hooks :). I'll review what I have and try to move this forward.

You have a lot of time invested in this :) I appreciate the enthusiasm to get a release. I will talk to klausi about making you a maintainer. You can find me on IRC as FatGuyLaughing

+++ b/role_export.module
@@ -13,7 +13,7 @@
 function role_export_init() {

Do we really want hook_init()? This is really a performance issues, as it is called on literally every page request.

+++ b/role_export.module
@@ -100,11 +100,11 @@ function role_export_theme() {
-    if ($cache) {
+    if ($cache && !$reset) {

Do we need that cache? We have removed to role cache in the 7.x branch, as this function is not called that often.

+++ b/role_export.module
@@ -112,16 +112,16 @@ function role_export_roles() {
+          db_query("UPDATE {role} SET rid = %d, machine_name = '%s' WHERE rid = %d", $new_rid, $value->machine_name, $value->rid);

Why can't you use drupal_write_record() here?

+++ b/role_export.module
@@ -161,4 +161,107 @@ function role_export_generate_id($mname) {
+/**
+ * Implement hook_drush_exit().
+ */

should be "Implements"

+++ b/role_export.module
@@ -161,4 +161,107 @@ function role_export_generate_id($mname) {
+/**
+ * Implementation of hook_features_api().
+ */

All new code should follow the latest documentation standards, i.e. "Implements hook_features_api()."

Otherwise I'm fine with adding you as a maintainer :-)

I have added you as maintainer of this project, so feel free to commit your stuff to the 6.x branch. Marking this issue as fixed, let's open new ones for any remaining problem(s).