I would like to add commas to thousands separators on the userpoints block.

CommentFileSizeAuthor
#1 format-userpoints-block-numbers_1317806_1.patch772 bytesjgsantos

Comments

jgsantos’s picture

jgsantos commented
Status: Active » Needs review
StatusFileSize
new format-userpoints-block-numbers_1317806_1.patch772 bytes

Here is a patch.

Status: Needs review » Needs work

The last submitted patch, format-userpoints-block-numbers_1317806_1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.0 » 7.x-2.x-dev
Category: task » feature
Priority: Minor » Normal

Using number format is specific to your site, other sites might not want this, so I won't accept a patch that adds this like this. Especially since it's not consistent with all the other places where it is displayed.

Instead, what I would like to see is a theme_userpoints() theme function which is used *everywhere* where points are displayed. Then you could could simply override the theme function and display points in any way you want.

Also not that will not be applied to the stable 7.x-1.x branch but only to the development branch 7.x-2.x

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Currently, there are no plans to improve the 7.x branch of this project with new features. Closing this by now as outdated. Please, feel free to reopen if you want to work on it.