Closed (won't fix)
Project:
Node Comments
Version:
6.x-2.0-beta7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Oct 2011 at 23:35 UTC
Updated:
16 Nov 2012 at 12:34 UTC
Hi crea,
I just saw you created a new branch for nodecomments. Keep up the good work!
This is a small problem in the 2.7 beta. If you can confirm the solution, I can write a patch for it.
Problem: New Comments don't get marked as such, because the preprocess function is broken.
Fix: Backport the commit for the 3.x branch (so weird, you committed this yesterday, and I work on it unknowingly today)
However, there is another problem in nodecomment_preprocess_node:
if (isset($node->view)) {
if (views_api_version() == 3) {
$cache = $node->view->display_handler->get_plugin('cache');
}
else {
$cache = $node->view->display_handler->get_cache_plugin();
}
if ($cache && get_class($cache) != 'views_plugin_cache_none') {
// Caching is enabled, so use tokens instead of real values.
...
}
}
For whatever reason, this doesn't work. It worked when I moved the $node->view display back in with the $cache checks:
if (views_api_version() == 3) {
$cache = $node->view->display_handler->get_plugin('cache');
}
else {
$cache = $node->view->display_handler->get_cache_plugin();
}
if (isset($node->view) && $cache && get_class($cache) != 'views_plugin_cache_none') {
// Caching is enabled, so use tokens instead of real values.
...
}
Comments
Comment #1
crea commented2.x is unlikely to get any support at this point. Closing all related issues.
Comment #1.0
crea commentedadded link to commit