Attached patch adds a "Neither" option for visibility settings, so you can have AES encrypted passwords, but not have them show to users anywhere.

In my case, I just want them available for Salesforce integration, not visible in the UI.

CommentFileSizeAuthor
#7 dont-show-passwords.patch1.01 KBtstoeckler
#5 dont-show-passwords-2.patch2.53 KBtstoeckler
dont-show-passwords.patch1.01 KBEvanDonovan

Comments

EvanDonovan’s picture

EvanDonovan commented
Issue tags: +7.x-1.6

Tagging.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work
Issue tags: -7.x-1.6

Patch looks great. Is something I have been wanting for ages.
One little thing we should fix, though:

+++ b/aes.module
@@ -157,9 +157,9 @@ function aes_config() {
+ '#description' => t('Whether to show the password as a collapsible box on the user info page (collapsed/hidden by default) on a separate page with a tab on the user page, on both, or neither.'),

"..., on both, or neither." is wrong. It should be "or", or ideally, just leave the word out alltogether. That would leave:
"Whether to show the password as a collapsible box on the user info page (collapsed/hidden by default) on a separate page with a tab on the user page, both, or neither."

EvanDonovan’s picture

EvanDonovan commented
Issue tags: +7.x-1.6

You are correct. Can you do me a favor & re-roll, though?

I have already applied all the other patches in the queue, so it would be harder for me.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Wow, that was a super-weird crosspost.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new dont-show-passwords-2.patch2.53 KB

There you go.

EvanDonovan’s picture

EvanDonovan commented
Status: Needs review » Needs work

This is the wrong patch :) Looks like a core patch.

I will probably re-roll w/in the next week or two with the revised text. Till then, bumping to "needs work" as a reminder.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new dont-show-passwords.patch1.01 KB

Wow, that's pretty weird..??!??!

Anyway, I "rerolled" by just editing the patch file...

dpovshed’s picture

dpovshed commented
Issue summary: View changes
Status: Needs review » Fixed

Patch from #7 committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit d3d83aa on 7.x-1.x, 8.x-2.x authored by tstoeckler, committed by dpovshed: 
    Issue #1318194 by tstoeckler, EvanDonovan: Make it possible to have AES...