With the move to changing the deltas for each bean, the #contextual_links array is broken in bean_block_view_alter. The array is expecting a numeric id vs. the new non-numeric delta.

I'm not sure where to adjust the "block" object to be sure to provide the "bid" from the {bean}.

CommentFileSizeAuthor
#6 contextual_links-1319918-6.patch434 bytesavr
#1 contextual_links-1319918-1.patch1.01 KBindytechcook

Comments

indytechcook’s picture

indytechcook commented
StatusFileSize
new contextual_links-1319918-1.patch1.01 KB

Try this. I haven't tested because I don't normally use contextual links.

Cheers :)

indytechcook’s picture

indytechcook commented
Status: Active » Needs review
avr’s picture

avr commented
Status: Needs review » Reviewed & tested by the community

Perfect - thanks for taking a look and offering the patch.

This module is great - thanks for the work and documentation on Treehouse/slides from camps. Super helpful.

mrfelton’s picture

mrfelton commented
Status: Reviewed & tested by the community » Fixed

This does the job. Patch committed http://drupal.org/commitlog/commit/22232/f7945784b76eadd5ee3d5599057f7bb...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avr’s picture

avr commented
Status: Closed (fixed) » Needs review
StatusFileSize
new contextual_links-1319918-6.patch434 bytes

With the update to Bean's use of Entity APIs, this is again broken. This time I actually see how things are working. Patch attached.

aheimlich’s picture

aheimlich
he/him
Primary language English
Location Chicago area
commented

I can confirm that the patch from #6 works.

indytechcook’s picture

indytechcook commented
Status: Needs review » Needs work 
+++ b/bean.moduleundefined
@@ -621,7 +621,7 @@ function bean_block_view($delta = '') {
-    $return['content']['#contextual_links']['bean'] = array('block', array($bean->internalIdentifier()));

Use the Identifier() method instead of the delta property. While it's the same thing in the end, it's good practice to use the API methods.

indytechcook’s picture

indytechcook commented
Status: Needs work » Active
Issue tags: +Needs tests

The fix is in. http://drupal.org/commitlog/commit/22232/88fbe423739a654cd1e0b5e53cdf138...

Setting this it Active and "needs tests" so we can add this to the list of bugs that need to be verified.

Cheers!

indytechcook’s picture

indytechcook commented
Issue tags: +Release blocker

Add Release Blocker

indytechcook’s picture

indytechcook commented
Status: Active » Fixed

Setting to fixed since I'm cross posting to #1160058: Make Tests

Automatically closed -- issue fixed for 2 weeks with no activity.