PMgrowl is set up and working properly on my site.

However, according to the Installation instructions:

5. Settings can be found at admin/settings/messages/pmgrowl

This is not so. However, under the Configuration -> Private Messages menu, Growl Notifications options are found.

The path for this is admin/config/messaging/privatemsg. I'm unsure that it's the same configuration set, as I cannot access admin/settings/messages/pmgrowl to compare them.

CommentFileSizeAuthor
#8 add_readme-1320068-8.patch615 bytessammyd56
#6 add_readme-1320068.patch605 bytessammyd56

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

No, this is correct, the README.txt hasn't been updated. Can you post a patch?

Satori42’s picture

Satori42 commented

I'm not sure I understand you. =)

Are you asking me to post a patch that corrects README.TXT's description of the Settings path?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: +Novice

Exactly :)

Sounds like a perfect task for learning how to create patches and deal with git if you don't know that already.

Satori42’s picture

Satori42 commented

Ah. Some other time? Such as soon when I learn development for Drupal. =)

At the moment I'm rushing to put together a huge site for an urgent purpose. Wanted to be sure to take a moment to post feedback for the module developers as I encountered errors though.

Additionally, just patching files within Windows 7 is hit-or-miss. Most of the applications for patching on Windows aren't functioning properly in the x64 architecture.

I appreciate the thought, though.

a_lawry’s picture

a_lawry commented

I can't see the README.txt in 7.x-1.x-dev? I'm happy to make the patch.

sammyd56’s picture

sammyd56 commented
Title: Settings page not found. » Add README.txt with correct settings location
Category: bug » task
Status: Active » Needs review
StatusFileSize
new add_readme-1320068.patch605 bytes

My first patch! Hope it's OK...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Patch itself is correct, two remaining issues below.

+++ b/README.txtundefined
@@ -0,0 +1,8 @@
+1. Download and extract this module and privatemsg module into your modules directory

.. download this and the privatemsg module...

+++ b/README.txtundefined
@@ -0,0 +1,8 @@
+2. Download the Growl plugin from http://www.stanlemon.net/projects/jgrowl.html and extract it inside of the pmgrowl module directory.
+3. Make sure that the jquery.jgrowl.css, and the jquery.jgrowl_minimized.js files are both directly inside of the pmgrowl/jgrowl directory.
+4. Enable the module
+5. Settings can be found at admin/config/messaging/privatemsg

Make sure that you wrap the lines at 80 characters, makes it easier to read in a console or another place where you have a limited/fixed width.

Powered by Dreditor.

sammyd56’s picture

sammyd56 commented
StatusFileSize
new add_readme-1320068-8.patch615 bytes

OK, here's a second attempt :)

sammyd56’s picture

sammyd56 commented
Status: Needs work » Needs review
diwant’s picture

diwant commented
Status: Needs review » Reviewed & tested by the community

I ran the patch. Works fine, creates the new README.txt. There are other problems the coder module points out, but this patch works as expected and within guidelines.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, finally commited, also updated the jgrowl URL. Poor little module...

Automatically closed -- issue fixed for 2 weeks with no activity.