I'm seeeing count() called 50,000 times in this function, it could just be !empty() instead.

CommentFileSizeAuthor
#1 count.patch645 bytescatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new count.patch645 bytes

And the patch.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

On first sight I don't see any problems with this patch so my vote is in. I think it's smart to wait on pwolanin's answer to see if this was a conscious decision (some quirk) or not. Thanks for finding this!

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 6.x-2.x-dev » 6.x-1.x-dev

The 6.x-2.x version has been deprecated. Moving this to 6.x-1.x-dev

Status: Needs review » Needs work

The last submitted patch, count.patch, failed testing.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs work » Fixed

Committed, Thanks

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Fixed » Closed (fixed)