Currently, we ship with a few specific file displays in the Media feature that aren't really useful unless you are using a layout similar to the one we use in the NodStream newspaper and blog products. These styles should be moved to the appropriate products, so that they don't clutter the interface for people implementing their own systems without the use of a product.

CommentFileSizeAuthor
#3 remove_ns_styles_dependency_1320610-3.patch455 bytespontus_nilsson

Comments

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented

Correct me if I'm wrong, but aren't these file styles currently bound to a specific theme (with a specific grid)? Having this in Nodestream makes #1320604: Make NodeStream theme-independent hard to implement?
Or are you thinking that one product holds the theme and layouts?

fabsor’s picture

fabsor commented
Title: Move size-specific file displays to an appropriate place » Remove dependency on ns_styles from ns_media

Come to think of it, we could keep this feature as it is and just have it enabled for products that are using the precision grid. The only thing we need to do in that case is to remove the dependency on ns_styles from ns_media, so you can use the media support we have without the specific styles.

pontus_nilsson’s picture

pontus_nilsson
Location Stockholm
commented
Status: Active » Needs review
StatusFileSize
new remove_ns_styles_dependency_1320610-3.patch455 bytes

To get this going supplied patch removes dependency on ns_styles in ns_media. This needs to be tested in a clean install with different products enabled.

fabsor’s picture

fabsor commented
Status: Needs review » Fixed

This will do just fine!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.