When you are on the review step, you get this error:

Notice: Undefined index: information in commerce_cod_submit_form() (line 118 of /home/ecom/public_html/shop/sites/all/modules/commerce_cod/commerce_cod.module).

Steps to reproduce:

1. Add an item to cart
2. Click checkout.
3. Fill in information, then "Continue to next step"
4. You get the error on the next page.

COD is the only enabled payment method.

CommentFileSizeAuthor
#2 1320636-fix_undefined_error.patch757 bytespcambra
commerce_cod-error.png6.59 KBelectricdot

Comments

maciej lukianski’s picture

maciej lukianski commented

You can just comment out the whole section and this line.

$form['commerce_cod_description'] = array(
'#markup' => $payment_method['settings']['information']
);

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 1320636-fix_undefined_error.patch757 bytes

No need to remove it, but put a wrapping condition

Basically if information is not required in the payment settings form, it should be checked.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

patch commited : http://drupalcode.org/project/commerce_cod.git/commit/1095685
thank you

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Thanks for committing this, please take a look to proper git attributions for future contributions :)

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs review » Fixed

sorry. i didn't know, i just used the : http://drupal.org/project/commerce_cod/git-instructions

may i have a little support, please.

for example, is this the right one?
git commit --author="pcambra <pcambra@122101.no-reply.drupal.org>" -m "Issue #[issue number] by [comma-separated usernames]: [Short summary of the change]."

what do you know, can i change the previous commits?

thank you.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

The code is right, i.e for this one the command would had been:

git commit --author="pcambra <pcambra@122101.no-reply.drupal.org>" -m "Issue #1320636 by pcambra: Undefined index error in commerce_cod_submit_form()."

You can't change commits once you've pushed :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.