hi,
1.) i please you to start a new branch for 6.x-4.x ?
2.) i prepeard a patch for some strings and added questions in comments there
-> may i ask you, to answer my questions?

3.) the module is translated
http://localize.drupal.org/translate/languages/de/translate?project=de_s...

can you check the translation and correct if neccesary?

CommentFileSizeAuthor
#1 string_n_questions-1320732-1.patch1.76 KBThomas_Zahreddin

Comments

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented
StatusFileSize
new string_n_questions-1320732-1.patch1.76 KB

and patch

schildi’s picture

schildi commented

Hello Thomas

  • First: Many thanks for your efforts translation "the module" !
    Some of your proposals could be a bit more compact in my eyes but I leave that up to you :-)
    Example:

    Implementiert einen Algorithmus (nach Martin Porter) zur Wortstammerkennung für die deutsche Sprache , um die Suche zu verbessern.

    Implementiert einen Algorithmus (nach Martin Porter) zur Verbesserung der Suche in deutschen Texten durch Wortstammbildung

    Wählen Sie Stoppwörter aus, die gelöscht werden

    Markieren Sie die zu löschenden Stoppworte

  • Hint: My goal was to keep each describing text as small and compact as possible.
    But your (longer) version is also possible.
  • Your proposal for the description "Preprocesing ..." looks not to be precise. The list of stop words and exceptions are managed, the preprocessing function itself is NOT managed.
  • Even: In a list containing an even number of words each two consecutive following two words build a key->value pair. Please take into account that in the current simple approach the key->value pairs are not tagged syntactically
  • Why do you ask for a new branch? Are there new functionalities?
Thomas_Zahreddin’s picture

Thomas_Zahreddin commented

hi Reiner,

thanks for your answers.

;-) You are free to add suggestions for better translations (the two above i added).

regarding the patch:

  • in the stemmer_api.info stemming should be with double m.
  • you commented $form['stemmer_api']['stemmers'] with
    list of stemmers impelenting search_preprocess

    the #options are $options_stemmers, which are built from module_implements('search_preprocess') (line 55), this list could include a lot of modules (in the moment there aren't many) and these modules implement search_preprocess - and that could be much more than stemming, see http://api.drupal.org/api/drupal/developer--hooks--core.php/function/hoo...
    e.g.:

    This is required for example to allow Japanese or Chinese text to be searched.

    so my conclusion: we don't know what exactly these modules implement and this fact should be reflected in the wording for the option list of stemmer_api.module.

regarding the branches:
;-) it was your choice to create a 6.x-4.0 version - so i expect this version in the branch 6.x-4.x .