I think it's a good idea to only use the javascript code on the pages you actually want to optimize.

My patch adds support for that, by default it keeps it enabled for all pages.

CommentFileSizeAuthor
#2 restrict-optimization-for-paths-7.x-1320876-2.patch1.66 KBCoornail
#1 restrict-optimization-for-paths-1320876-1.patch1.66 KBCoornail

Comments

Coornail’s picture

Coornail commented
StatusFileSize
new restrict-optimization-for-paths-1320876-1.patch1.66 KB

This is agains 6.x head.

Coornail’s picture

Coornail commented
StatusFileSize
new restrict-optimization-for-paths-7.x-1320876-2.patch1.66 KB

This is the straight cherry-pick ported to 7.x.

I heaven't tested this one.

elc’s picture

elc commented
Assigned: Unassigned » elc
Status: Needs review » Postponed
Issue tags: +added to 1.1-dev

Awesome; Thank you :) This was one of the things on my TODO list in the README.

I was thinking expanding on this a little bit more to follow the same rules and layout as the block page filtering which uses 'User specific visibility settings', 'Role specific visibility settings', and 'Page specific visibility settings'. I can't simply plonk the code into a block since it needs to be loaded in hook_init, but it would be nice to have the same kind of filtering.

I'm presently working in dev sub-branch which I'm not quite ready to commit to the main dev branch. It's full of @todo comments and massive sections of commented out code, so I can't apply this patch directly. I have included the filtering settings in that dev branch though, so as soon as I push it they will be in there.

Changed to postponed for now, but I expect to be pushing that update either in the next few hours, or this weekend. I'll swap to fixed and publish a dev release at the time.

Thanks again for the patch as I wasn't going to include the filtering in this next version.

elc’s picture

elc commented
Status: Postponed » Patch (to be ported)

The 6.x-1.x branch now has the latest code in it which includes a lightly more complex version of this fix, along with better help text, and a user friendly Account ID parser.

http://drupalcode.org/project/visual_website_optimizer.git/commit/bd82c44

If you could test out the 6.x-1.x branch, that would be great. I haven't been able to do much testing of it myself, so I have simply enabled the dev release branch for now.

Coornail’s picture

Coornail commented

Hi!

I expect that next week I can take the module for a test ride =)
I'll ping you.

moshe weitzman’s picture

moshe weitzman commented

Anyone available to port this to Drupal 7 version? It is an unfortunate situation to have D6 ahead of D7.

elc’s picture

elc commented
Status: Patch (to be ported) » Fixed

I haven't heard back from testing on the D6 version. I'll throw those changes into the D7 dev version (dev version published on the 31st of January) and see if there is more of a comment there. Without getting some feedback, I'm not all that confident about making a new release. I no longer have an active VWO account which also makes testing a little difficult.

Also added the experimental beta async code support #1344142: Add Support Option to toggle between Asynchronous/Synchronous Code Snippets. It defaults to synchronous.

It's not all that strange for the D6 version to be available prior to the D7 version on something that was originally written in D6.

Please let me know how you go with this code and if there are any bugs so that I can push these to full release.

Automatically closed -- issue fixed for 2 weeks with no activity.