Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This tiny patch adds a missing period to the end of the drupal_set_message.
| Comment | File | Size | Author |
|---|---|---|---|
| privatemsg_add_period.patch | 1.06 KB | kiz_0987 |
Comments
Comment #1
umonkey commented%url is wrong; make it @url or !url.
Comment #2
kiz_0987 commentedMaybe so, but this patch does not touch that part. If the change is required as you suggest then it will need to be made in many more places.
Comment #3
umonkey commentedWhat do you mean by "does not touch that part"? This patch changes the message, it screws up all localizations (for this message), so I think it shouldn't replace one malformed message to another one, differently malformed.
Comment #4
kiz_0987 commentedYes, I agree that this will mess up the localizations. Not much I can do about that. What I mean with the "not touch that part" is that this patch only makes 2 changes -- it adds 2 periods. It has not incorrectly changed an original @url or !url to %url, because it is currently %url. There are other places where % is used too, for example in privatemsg_help %privatemsg is used and then on the next line !privatemsg is used. There is probably some work to do to make all this consistent -- this is not something I plan. Honestly I'm regretting putting in this simple patch given the approach that you have taken to providing feedback.
Comment #5
mindless commentedit always bugs me when i submit a patch and get complaints about preexisting things.. don't worry, i won't make you deal with that.
Comment #6
mindless commentedadded the periods, also added a period on one more drupal_set_message call where the text didn't have one.
also changed %url to !url.. the code works (this is a strtr call, not a t() call), but seems good to change it for consistency with how t() works (also I got an API change into 6.x so format_plural will accept tokens directly).
I updated existing translations for the period and %/! changes.
committed on DRUPAL-5 branch.
Comment #7
(not verified) commented