The following code produces unwanted markup when the user does not have permission to post comments and there are no other links:
<?php if ($links = render($content['links'])): ?>
<nav><?php print $links; ?></nav>
<?php endif; ?>
The resulting markup is:
<nav><ul class="links inline"><li class="comment-forbidden first last"></li></ul></nav>
The following code in comment_links() causes this to happen:
else {
$links['comment-forbidden']['title'] = theme('comment_post_forbidden', array('node' => $node));
$links['comment-forbidden']['html'] = TRUE;
} | Comment | File | Size | Author |
|---|---|---|---|
| #19 | assertCommentLinks_d8_backported_to_d7-1321248-19.patch | 2.25 KB | diego21 |
| #17 | assertCommentLinks_d8_backported_to_d7-1321248-17.patch | 1.51 KB | diego21 |
| #11 | comment-forbidden-1321248-11-d7.patch | 624 bytes | Bußmeyer |
| #6 | comment-forbidden-1321248-06-d7.patch | 624 bytes | Bußmeyer |
| #3 | comment-forbidden-1321248-03.patch | 644 bytes | kathyh |
Comments
Comment #1
jacineNot sure if this is the proper way to fix this, but here's a patch to review.
Comment #2
xjmI think there's a big meta issue somewhere about whether to use this sort of pattern when an element should be empty. Unfortunately I can't find it at the moment, though...
In any event, we'll need to reroll this now. Tagging as novice for the task of rerolling the Drupal 8.x patch.
If you need help rerolling this patch, you can come to core office hours or ask in #drupal-gitsupport on IRC.
Comment #3
kathyh commentedRe-rolled for #2 D8 /core. After botcheck - back to big meta issue discussion.
Comment #4
star-szrI'm not sure where the meta discussion is, but the patch in #3 still applies cleanly to D8 head, so tagging for tests.
Comment #5
ivan zugec commentedI can't replicate this issue on the latest 8.x-dev, looks like it's been fixed. If a user doesn't have the right permissions, they'll see the following markup:
<ul class="links inline"><li class="comment-forbidden odd first last"><span><a href="/user/login?destination=node/1%23comment-form">Log in</a> or <a href="/user/register?destination=node/1%23comment-form">register</a> to post comments</span></li></ul>There's also a test within the assertCommentLinks() method.
Comment #6
Bußmeyer commentedJust created a patch for D7 that is based on the patch #3.
Comment #8
star-szrIssue needs to be set to 7.x for testing the patch in #6.
Comment #9
star-szr#6: comment-forbidden-1321248-06-d7.patch queued for re-testing.
Comment #11
Bußmeyer commentedI modified the patch for D7. There was a little typo in it.
Comment #12
Bußmeyer commentedComment #13
droplet commentedD8 first
Comment #14
BrockBoland commentedAccording to #5, this has been fixed in D8. The patch in #11 needs to be tested for D7, and test needs to be written.
Comment #15
Bojhan commentedWorks for me, does this really need tests? Silly issue.
Comment #16
webchickWell if we already have tests for D8 (as indicated in #5), we should get 'em backported to D7.
Comment #17
diego21 commentedI did this patch using Drupal 8 assertComentLinks() as source, as was said in #16. I don't know if it's correct or how test it in Drupal 7. Can someone tell me how can I do it? Thanks in advance!
Comment #19
diego21 commentedTrying again :D.
Comment #20
diego21 commentedComment #22
diego21 commentedAnyone could tell me how can I test this patch? Thanks! :D
Comment #23
dercheffeHello @all,
I have exactly the same problem in my Drupal-installation (Drupal 7.41).
If a user is not logged in, the node links do not appear like in the bug description mentioned. The normal behaviour of a fresh core installation is, that there appears a message "please log in or register to post a comment". This message is unfortunately missing in my drupal. If the user is logged in, then all node links are shown correctly. Is there already a solution of the problem?
To adjust my settings more precise, I use the module "field permission". Maybe there be a bug too?
Best whises,
Phil