Patch checks user is logged in, and removed hardcoded a href

CommentFileSizeAuthor
fbconnect-user-block.patch1.89 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

This is now in my sanbox -- https://github.com/amitaibu/fbconnect , which overhauls some of the messy parts of fbconnect.

bartl’s picture

bartl commented

Wow, you're my hero! I was so annoyed with this "Login with Facebook" block when a user is already logged in, it's unnecessary and confusing for the user because it suggests that he is not logged in. I was already planning on editing that myself, locally.

I've had a quick look at your sandbox, it looks interesting... I was wondering if the recent official patches here are already incorporated too? Especially the "update PHP SDK to 3.1.1" stuff... Hmm, probably not.

bartl’s picture

bartl commented

I have installed your sandbox version, and a closer look at diff told me that you apperently have patched the SDK 3.1.1. issue as well, though the not so recent date of the last updates on the git repository had made me not expect it.

It's looking good, though I still have some problems; but that would seem more of a buggy Facebook system than anything else. Do millions of people actually have to suffer this buggy and weak interface? It's hard to believe.

jcisio’s picture

jcisio commented
Status: Needs review » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.