Right now it's impossible to extend Memcache due to some private methods.

Here's the simple fix.

CommentFileSizeAuthor
memcache-protected-methods.patch1.38 KBdixon_

Comments

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

Just now I can't figure out what that last row change does or where it comes from. It seems to be a tricky line break or white space. The code and spacing between functions looks good.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

As discussed with catch, the plan is to split up these crazy huge and complex functions into separate things once the 7.x-1.x branch is *finally* stable.

However, nothing wrong with making them protected in the meantime I guess..

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Looks fine to me, committed and pushed to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Could this be backported to D6? I'll roll a patch if you'd be willing to accept it?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Nemind, the D6 and D7 codebases are *completely* different.