Access Rules in Panels not working

domain.inc line 102:

if ($key == $_domain['machine_name']) {

must be

if ($value == $_domain['machine_name']) {

Can anybody confirm please.

I first postetd it has to be

if ($value == $_domain['machine_name']) {

but it must be:

if ($value === $_domain['machine_name']) {

(Don't know exactly why, but the first code gives me a (0 == "domain_1") is true. I'm confused, but with type checking (===) it works fine.)

I will write more in a few minutes.

Thank you for your quick reply and changing the title back (thought it was the title for the comment).

Let me explain without the panels export (it is ok), that might be more helpful:

Look at function domain_ctools_domain_access_check($conf, $context, $plugin) in domain.inc.

function domain_ctools_domain_access_check($conf, $context, $plugin) {
  $_domain = domain_get_domain();
  if ($conf['domain_site']) {
    return TRUE;
  }
  // Check each domain, converting -1 to 0.
  foreach ($conf['domains'] as $key => $value) {
    $id = ($key == -1) ? 0 : $key;
    if (domain_ctools_api_version() < 3) {
      if (abs($value) > 0 && $id == $_domain['domain_id']) {
        return TRUE;
      }
    }
    // Normal 7.x.3 support.
    if ($key == $_domain['machine_name']) {
      return TRUE;
    }
    // Legacy 7.x.2 checking.
    if ($key == -1 || ($id > 0 && intval($key) == $key)) {
      if (abs($value) > 0 && $id == $_domain['domain_id']) {
        return TRUE;
      }
    }
  }
  return FALSE;
}

If you var_dump the $conf variable you get something like this, if the second domain is selected:

array(2) {
  ["domain_site"]=>
  int(0)
  ["domains"]=>
  array(3) {
    ["domain_1"]=>
    int(0)
    ["domain_2"]=>
    string(22) "domain_2"
    ["domain_3"]=>
    int(0)
  }
}

While looping through the conf['domains'] you get the $key and $values, but for 7.x.3 support you can see the code:

if ($key == $_domain['machine_name']) {
      return TRUE;
    }

Lets assume you load this page from "domain 1" but the first panel is configured to appear on "domain 2".
So this function is called for the first panel. Now the loop runs and will get a TRUE when the loop reaches the first domain, because the $key is definitly the domain machine name (see the array dump above). -> Panel 1 is displayed, but thats not correct.
You must check for the $value to be the domain machine name (and not 0). In this example "domain_1" is not existent in any $value, so the panel is not displayed.
If you load this page on "domain 2", the loop checks for the $value "domain_2" and it gets a true in the second loop. -> Panel will be displayed.

If you want to get my panel export anyway let me know.

Yes, with 7.x.3 $key is a string.

Nevertheless in the 7.x.3 loop the $value must be compared to the domain machine name, not the $key. The problem itself is caused by that, not by the format of the $key index.

Don't know the $conf array of 7.x.2, maybe it is neccessary to check still for $key to be string, so that the right code for 7.x.3 is used.

So I think it should be

// Normal 7.x.3 support.
    if ($key === $_domain['machine_name']) { // check for 7.x.3
        if ($value === $_domain['machine_name']) { // check for domain to be used
          return TRUE;
        }
        return false; // return false when 7.x.3 but not right domain, so that 7.x.2 code below ist not executed
    }

The panel export is attached, I renamed the domains to "domain1_de", "domain2_de" and "domain3_de".

Here an excerpt of the rule for the first panel (for domain1).

$handler->conf = array(
  'access' => array(
    'plugins' => array(
      0 => array(
        'name' => 'domain',
        'settings' => array(
          'domain_site' => 0,
          'domains' => array(
            'domain1_de' => 'domain1_de',
            'domain2_de' => 0,
            'domain3_de' => 0,
          ),
        ),
        'not' => FALSE,
      ),
    ),
    'logic' => 'and',
  ),
);

I think #8 would be a better solution to respect Domain Access 7.x.2. But I didn't test it.

Seems to work.

Testet with:

- Domain Ctools 7.x-1.2
- Domain Access 7.x-2.15

AND

- Domain Ctools 7.x-1.2
- Domain Access 7.x-3.0-rc4

New release tested. Seems to work.

Thank you!

edit