- "View" tabs always appear on nodes for all users
- Nodes that don't exist result in "Access denied" rather than "Page not found"
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | single_tab_fix_2.patch | 2.98 KB | pwolanin |
| #2 | single_tab_fix_1.patch | 2.26 KB | pwolanin |
- "View" tabs always appear on nodes for all users
- Nodes that don't exist result in "Access denied" rather than "Page not found"
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | single_tab_fix_2.patch | 2.98 KB | pwolanin |
| #2 | single_tab_fix_1.patch | 2.26 KB | pwolanin |
Comments
Comment #1
pwolanin commentedFor me, I get "Page not found" for a non-existent node link (node/99999). Can you double-check?
for the tabs, seems I missed a line from chx's patch when I redid it (sorry): http://drupal.org/node/115847
the patch should look like:
Comment #2
pwolanin commentedok, here's a patch for the single tab issue. Seems to work, though perhaps someone can think of a more elegant construction.
Comment #3
webernet commentedTested the patch, everything seems to be working properly, single tabs are no longer being shown.
I am still getting "Access denied" instead of "Page not found" for non-existent nodes, but that can be taken care of in another issue.
Comment #4
chx commentedComment #5
pwolanin commentedminor additional fix - should return an empty string, not an array, if the path is not found/denied
Comment #6
Steven commentedTested and works as expected. Something tells me that repeated code in menu_local_tasks() could be refactored though...
Committed to HEAD.
Comment #7
pwolanin commentedI will look into refactoring as part of the menu system performance patch that I will start working on once the current book and menu patches get in.
Comment #8
(not verified) commented