Closed (fixed)
Project:
Event Repeat
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 Mar 2007 at 19:43 UTC
Updated:
27 Jan 2009 at 01:00 UTC
See here:
I'd like to provide patches to achieve a compatible version of event repeat.
Could we agree on letting me directly work on the HEAD branch of event repeat and later create a Drupal-5--2 branch from that?
Comments
Comment #1
seanbfuller commentedThanks fine with me.
Quick questions just for my own education:
Are we moving away from Unix timestamps for performance?
Are we allowed to do this because Drupal doesn't support mysql 3 as of Drupal 5?
Will this break support for date module? If so, will date module be moving in this direction?
Sorry if some of those are dumb questions, I just want to make sure I understand. Thanks!
Comment #2
killes@www.drop.org commentedNo, this has no performance reasons. With unix timestamps we've often had issues where events would move from one month to the next and it was rather hard to find out what caused this. with the new storage mechanism we can clearly see the date that the user put into the form.
Yes, this will break stuff for all modules that use the date table. I will be working on eventrepeat because it is within the scope of the current project. Other people will have to migrate on their own. I will of course try to keep changes to a minimum and provide an upgrade path for existing data (of event module and evnetrepeat module). I also hope to provide upgrade instructions of other modules using the event API.
I'd appreciate if people would be willing to test my changes as I commit them to CVS.
Comment #3
seanbfuller commentedSorry, I thought I had responded to this, and I just noticed that I hadn't.
Feel free to use HEAD. If any changes come up that I think need to go in there, I'll let you know before I do it, just so you know the state of the code.
Comment #4
seanbfuller commentedChanging the name of this issue just to help keep the battle plan straight.
Comment #5
killes@www.drop.org commentedI have committed an initial version of the code to cvs. There are still several problems, but I thought I'd let you help me with them. ;)
One known issue is that editing does not work yet.
Comment #6
seanbfuller commentedA 5.x-2.x branch has been created from head. Marking this as fixed. Please post additional issues and patches for this version as the proper branch (it should be showing up in the list soon).
Comment #7
(not verified) commentedComment #8
nancydruIt's been almost a month and it is still not showing up! What's up?
Comment #9
seanbfuller commentedI created a release for 5.x-2.x-dev a while back, but it's now showing up on the module page. Not sure why. I removed the "New Features" tag, thinking maybe it will show up now. You can see it on the "View all releases page." You can also get it from cvs.
If anyone has a hint on how to make it show up on the module page, let me know.
Comment #10
rconstantine commentedDid you 'Add new release'? That does it for me with new branches.
Comment #11
rconstantine commentedBTW, has this effort stalled?
Comment #12
seanbfuller commentedStill not sure why this is not showing up on the project page, but it is listed under releases.
The 5.x-2.x branch has a few things that need to be fixed (exceptions being a big one), but otherwise I think killes, etc., have finished their version. You can see the issues in the queue. I'll try to take a look at wrapping these up soon. As always patches welcome.
Comment #13
manerhabe commentedHmm, maybe I am missing something but I still don't see the 5.x-2.x version under releases.
Comment #14
seanbfuller commentedYeah, I'm not sure why it isn't catching the branch from cvs to make that release. I'll see if I can dig a bit deeper to find it.
Comment #15
rconstantine commentedI finally ran into the same problem and the solution is somewhat obvious.
From your project's main page, click on the 'edit' tab.
Then click on the 'Releases' link/secondary tab.
You should have a selection box for choosing the 'Major version'.
Choose 2.
Save.
Ta-da!!!
Comment #16
WeRockYourWeb.com commentedHere's a link until you get it working: eventrepeat-5.x-2.x-dev.tar.gz
Comment #17
seanbfuller commentedI've tried your suggestions and still could not get it to work. All the options seem to be set correctly, but there is still no download link and it won't show up on the project page. As it is unstable, your best bet is still to get the code through cvs if you have that option. I've contacted dww and asked him to take a look to see if I missed something obvious. Until then, our best bet is probably to concentrate on getting it stable and creating a .0 release in the hopes we'll have better results there.
Comment #18
rconstantine commentedIn that case, I would imagine that showing a 2.x release depends on the existence of a 2.0 release (or other tag, not branch). Anyway, I've been meaning to help out with the current efforts but haven't had time. Sounds like you know how that is...
Comment #19
Steve Dondley commentedCan I recommend manually putting a link to this release on the project page in the meantime? I just happened to stumble upon this page.
Comment #20
seanbfuller commentedThanks to some help from dww, this version is now generating a tarball. You will have to click on the "all releases" link to get it. According to him, it won't be on the project page until it is the suggested version. We'll need to get to some of these bugs before that happens, obviously. I am hoping that this month is a bit better for me than the last few. I hope to spend some much needed time on this soon.
Comment #21
rmiddle commentedWell 5.x-2.x is on the front page now. So this issue is fixed.
Thanks
Robert